Skip to content

notification #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Nov 16, 2024
Merged

notification #1207

merged 53 commits into from
Nov 16, 2024

Conversation

adred
Copy link
Contributor

@adred adred commented Nov 6, 2024

No description provided.

@adred adred marked this pull request as draft November 6, 2024 13:30
@adred adred marked this pull request as ready for review November 7, 2024 02:04
@adred adred marked this pull request as draft November 7, 2024 05:24
@adred adred marked this pull request as ready for review November 11, 2024 08:39
adred and others added 19 commits November 11, 2024 21:04
@adred
minor fix
cef5fbc
@adred
improvements and cleanup
ff9aba9
@adred
only enable in dev for now
2b1478d
@adred
license
55cf977
@adred
Merge branch 'main' of github.com:wavetermdev/waveterm into red/notif…
ea3a8fc 
…ication
@adred
replace NotificationTypes with string literal union
5ddca1a
@adred
title color must match the icon color
b4aa0f7
@adred
implement removeNotificationById global function
6ef7d8a
@adred
remove existing notification with same id
83d1879
@adred
fix padding spacing issue
8796d62
@adred
set default icon to bell for notification item
f4bde8b
@adred
when clicking Clear, its should remove all inclusing persistent ones
8e9721b
@adred
when toggling to show list, hide all all notifications
38af2e7
@adred
don't allow pushing notification when it's persistent but no id is pr…
fae6ed7 
…ovided
@adred
use lock icon for persistent notifications
124bbf4
@adred
persistent notification shouldn't be cleared
51fc5a6
@adred
icon styles adjustment
772adf4
@adred
shoulde be 'Cannot be cleared'
410c6c8
@sawka
invert isDev() (updater notifications)
2e8816d
@sawka sawka merged commit f64863c into main Nov 16, 2024
5 of 6 checks passed
@sawka sawka deleted the red/notification branch November 16, 2024 05:26
xxyy2024 pushed a commit to xxyy2024/waveterm_aipy that referenced this pull request Jun 24, 2025
@adred
notification (wavetermdev#1207)
8135b41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adred @sawka @esimkowitz