Skip to content

Workspaces are back! #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 78 commits into from
Dec 2, 2024
Merged

Workspaces are back! #1282

merged 78 commits into from
Dec 2, 2024

Conversation

esimkowitz
Copy link
Member

No description provided.

@esimkowitz esimkowitz marked this pull request as ready for review November 23, 2024 01:11
@chottuthejimmy
Copy link
Contributor

@esimkowitz the test failed for this PR, there's a blank gray screen when the application is opened.
This was the downloaded artifact

Check it out and lmk if its an issue with the PR itself or something from our end.

@esimkowitz
Copy link
Member Author

Requested access to view the result

@chottuthejimmy
Copy link
Contributor

Wdym access ?
You don't have the access to view the recordings ? Like any of the test results ?

Super sorry for that.
Just curious, who has got access to the rec from your org ?
Basically there will be a dashcam account for your org through which the api is added to the repos secrets.
I am not sure tho, if ian just added the api from his side without creating a dashcam account for you guys.

If you do have the dashcam account, just ask the admin to add you over there and you will have access to all the rec

Once again sorry for the inconvenience mate 😔 we will have it fixed by the night!

@ianjennings
Copy link
Contributor

ianjennings commented Nov 27, 2024

Hey @esimkowitz,

I've updated the last replay from CI to be available, and all future replays within your account as "unlisted."

Here is the replay:
https://app.dashcam.io/replay/6742361ce20755e5ae468a8b?share=nKRKfxGbBkDsE9j9jQRw

Can you please check your email for an invite to the Dashcam team? It may be a few months old.

Ian

@esimkowitz
Copy link
Member Author

@chottuthejimmy @ianjennings found the issue, should be fixed now

@esimkowitz
Copy link
Member Author

Also @ianjennings found the email and joined the team, thanks for the heads-up!

@esimkowitz esimkowitz merged commit 82f53dc into main Dec 2, 2024
4 of 6 checks passed
@esimkowitz esimkowitz deleted the evan/workspace-0.9 branch December 2, 2024 18:56
@chottuthejimmy
Copy link
Contributor

@chottuthejimmy @ianjennings found the issue, should be fixed now

I think this would be our first automated test which actually caught a bug! 🎉

xxyy2024 pushed a commit to xxyy2024/waveterm_aipy that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants