Improvements suggested in the review #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
cborla
deleted the branch
enhancement/17-migrate-syscollector-to-inventory-at-new-agent
nbertoldo
force-pushed
the
enhancement/17-improvements-suggested-in-the-review
branch
3 times, most recently
from
568c5d9
to
19af211
Compare
nbertoldo
force-pushed
the
enhancement/17-improvements-suggested-in-the-review
branch
4 times, most recently
from
380c84d
to
4c19f2f
Compare
LucioDonda
force-pushed
the
enhancement/17-migrate-syscollector-to-inventory-at-new-agent
branch
from
b8fe691
to
e8c737f
Compare
refactor: migrate data-provider WIP refactor: data-provider migration WIP
refactor: migrated common modules (WIP) refactor: migrate common modules (WIP) refactor: migrate common modules compiles
…, Alpine, Arch Linux
nbertoldo
force-pushed
the
enhancement/17-improvements-suggested-in-the-review
branch
from
4c19f2f
to
a72f7db
Compare
cborla
merged commit 4537aa5
into
enhancement/17-migrate-syscollector-to-inventory-at-new-agent
1 of 5 checks passed
cborla
deleted the
enhancement/17-improvements-suggested-in-the-review
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes several corrections and improvements requested by the team in the revision of #45.
Configuration options
Logs/Alerts example
Tests