-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changes to persist agent_group information and perform file download requests #224
Add changes to persist agent_group information and perform file download requests #224
Conversation
64cea84
to
0d51b92
Compare
00fdb62
to
0a0cd06
Compare
@@ -75,6 +86,22 @@ void AgentInfoPersistance::CreateAgentInfoTable() | |||
} | |||
} | |||
|
|||
void AgentInfoPersistance::CreateAgentGroupTable() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a table for the agent group? Can't it be just another column in the agent_info
table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that in the future more information related to the groups could be added, for example the hash of the configuration file of each group to check that it has not been modified. That's why I thought about adding a new table.
We should add to this PR passing the new functions to the void SetGroupIdFunction(SetGroupIdFunctionType setGroupIdFunction);
void GetGroupIdFunction(GetGroupIdFunctionType getGroupIdFunction);
void SetDownloadGroupFilesFunction(DownloadGroupFilesFunctionType downloadGroupFilesFunction); This can be done somewhere in |
In reference to this comment:
These changes will be added in PR #223. |
1aafdda
to
dfd0d73
Compare
…tion in the agent_info.db database (inside a new table, the agent_group table).
…asses to read the request response and store it in a file.
…ass to make a request and download a file.
…ttpRequestDownload)
…entInfoPersistance class.
…ods of the HttpSocket and HttpsSocket classes.
dfd0d73
to
e6976c1
Compare
…cator class to perform group file download requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds the changes to persist the groups to which the agent belongs and also adds the changes to HttpClient to be able to perform file download requests.
Tests