Skip to content

Fix Agent Registration Behavior #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 19, 2024
Merged

Fix Agent Registration Behavior #319

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d49f9c9
fix(agent): prevent implicit agent info persistence on change
vikman90 Nov 19, 2024
848e6ab
feat(agent): persist agent info on successful registration only
vikman90 Nov 19, 2024
3ada0d9
test(agent): update persistence policy in agent info unit tests
vikman90 Nov 19, 2024
c760a31
test(agent): update persistence policy in agent registration unit tests
vikman90 Nov 19, 2024
dbff0d5
fix(agent): expect status code 201 at registration request
vikman90 Nov 19, 2024
bb77327
fix: fix style checks in agent_info.cpp file
TomasTurina Nov 19, 2024
ba66f7a
fix: AgentRegistration tests changes
jr0me Nov 19, 2024
bd62a34
fix: Update AgentInfo methods' documentation
jr0me Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions src/agent/tests/agent_registration_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,17 @@ TEST_F(RegisterTest, RegistrationTestSuccess)
AgentInfoPersistance agentInfoPersistance;
agentInfoPersistance.ResetToDefault();

registration = std::make_unique<agent_registration::AgentRegistration>(
"user", "password", "4GhT7uFm1zQa9c2Vb7Lk8pYsX0WqZrNj", "agent_name", std::nullopt);
SysInfo sysInfo;
agent = std::make_unique<AgentInfo>([&sysInfo]() mutable { return sysInfo.os(); },
[&sysInfo]() mutable { return sysInfo.networks(); });

agent->SetKey("4GhT7uFm1zQa9c2Vb7Lk8pYsX0WqZrNj");
agent->SetName("agent_name");
agent->Save();

registration = std::make_unique<agent_registration::AgentRegistration>(
"user", "password", "4GhT7uFm1zQa9c2Vb7Lk8pYsX0WqZrNj", "agent_name", std::nullopt);

MockHttpClient mockHttpClient;

EXPECT_CALL(mockHttpClient, AuthenticateWithUserPassword(testing::_, testing::_, testing::_, testing::_))
Expand Down Expand Up @@ -152,29 +157,16 @@ TEST_F(RegisterTest, RegistrationTestSuccessWithEmptyKey)

registration =
std::make_unique<agent_registration::AgentRegistration>("user", "password", "", "agent_name", std::nullopt);
SysInfo sysInfo;
agent = std::make_unique<AgentInfo>([&sysInfo]() mutable { return sysInfo.os(); },
[&sysInfo]() mutable { return sysInfo.networks(); });

MockHttpClient mockHttpClient;

EXPECT_CALL(mockHttpClient, AuthenticateWithUserPassword(testing::_, testing::_, testing::_, testing::_))
.WillOnce(testing::Return("token"));

const auto bodyJson = agent->GetMetadataInfo(true);

http_client::HttpRequestParams reqParams(boost::beast::http::verb::post,
"https://localhost:55000",
"/agents",
agent->GetHeaderInfo(),
"token",
"",
bodyJson);

boost::beast::http::response<boost::beast::http::dynamic_body> expectedResponse;
expectedResponse.result(boost::beast::http::status::ok);

EXPECT_CALL(mockHttpClient, PerformHttpRequest(testing::Eq(reqParams))).WillOnce(testing::Return(expectedResponse));
EXPECT_CALL(mockHttpClient, PerformHttpRequest(testing::_)).WillOnce(testing::Return(expectedResponse));

// NOLINTNEXTLINE(cppcoreguidelines-init-variables)
const bool res = registration->Register(mockHttpClient);
Expand Down