Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS version to messages metadata #320

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

TomasTurina
Copy link
Member

@TomasTurina TomasTurina commented Nov 19, 2024

Related issue
#316

Description

This PR includes the OS version in the agent metadata. This includes:

  • Registration requests.
  • Stateless requests.
  • Stateful requests.

Logs/Alerts example

Register:

{
    "groups": [],
    "host": {
        "architecture": "aarch64",
        "hostname": "tomas",
        "ip": [
            "192.168.64.16",
            "fde7:1d32:1c4f:33cc:70ef:32ff:fecc:228b"
        ],
        "os": {
            "name": "Ubuntu",
            "platform": "Linux",
            "version": "22.04.5 LTS (Jammy Jellyfish)"
        }
    },
    "id": "784832cf-f189-4da8-8abd-b5b99a23e9a2",
    "key": "KPhX7AZXe3FK32wj1hKFaZG8RnfdDRnE",
    "name": "tomas",
    "type": "Endpoint",
    "version": "5.0.0"
}

Stateful/stateless:

{
    "agent": {
        "groups": [],
        "host": {
            "architecture": "aarch64",
            "hostname": "tomas",
            "ip": [
                "192.168.64.16",
                "fde7:1d32:1c4f:33cc:70ef:32ff:fecc:228b"
            ],
            "os": {
                "name": "Ubuntu",
                "platform": "Linux",
                "version": "22.04.5 LTS (Jammy Jellyfish)"
            }
        },
        "id": "784832cf-f189-4da8-8abd-b5b99a23e9a2",
        "name": "tomas",
        "type": "Endpoint",
        "version": "5.0.0"
    }
}

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X

@TomasTurina TomasTurina self-assigned this Nov 19, 2024
@TomasTurina TomasTurina linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomasTurina TomasTurina merged commit 95e8fef into master Nov 19, 2024
5 checks passed
@TomasTurina TomasTurina deleted the feat/316-add-os-version branch November 19, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OS Version to Agent Headers
3 participants