Skip to content

Conversation

LucioDonda
Copy link
Member

@LucioDonda LucioDonda commented Mar 26, 2025

Description

Closes #694

The installer provides a default configuration file, wazuh-agent.yml. This file contains numerous settings but is specifically tailored for Linux.

The final version of the agent will likely have a minimal configuration. The manager will transmit a more complete configuration, adapted to its platform and configuration group.

However, to facilitate testing, we should provide a default configuration file that is more suitable for each platform (Linux, Windows, and macOS), allowing the agent to be tested without requiring any configuration.

Tasks

  • Split the configuration into three files:
    • wazuh_agent_linux.yml
    • wazuh_agent_windows.yml
    • wazuh_agent_macos.yml
  • Propose a suitable default configuration for each platform.
  • Adapt the installer to copy the appropriate configuration file for the platform.

Acceptance Criteria

  • The installer copies the appropriate configuration file for the platform.

Proposed Changes

Configuration Changes

  • In windows platforms hotfixes will be set to true by default, false in other cases.

Review Checklist

  • Code changes reviewed
  • Relevant evidence provided
  • Tests cover the new functionality
  • Configuration changes documented
  • Developer documentation reflects the changes
  • Meets requirements and/or definition of done
  • No unresolved dependencies with other issues

@LucioDonda LucioDonda linked an issue Mar 26, 2025 that may be closed by this pull request
@LucioDonda LucioDonda self-assigned this Mar 26, 2025
@LucioDonda LucioDonda force-pushed the enhancement/694-define-a-default-configuration-per-platform branch 9 times, most recently from f8277b3 to 634fa5c Compare March 31, 2025 20:54
@LucioDonda LucioDonda marked this pull request as ready for review March 31, 2025 20:59
@LucioDonda LucioDonda requested review from cborla and nbertoldo March 31, 2025 20:59
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the linux default configuration, we should include the journald default configuration. Everything else looks good.

@LucioDonda LucioDonda force-pushed the enhancement/694-define-a-default-configuration-per-platform branch from 634fa5c to db6148e Compare April 1, 2025 13:35
@LucioDonda LucioDonda requested a review from cborla April 1, 2025 13:39
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Code changes reviewed
  • Relevant evidence provided
  • Tests cover the new functionality
  • Developer documentation reflects the changes
  • Meets requirements and/or definition of done
  • No unresolved dependencies with other issues

Copy link
Member

@nbertoldo nbertoldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Code changes reviewed
  • Relevant evidence provided
  • Tests cover the new functionality
  • Developer documentation reflects the changes
  • Meets requirements and/or definition of done
  • No unresolved dependencies with other issues

@cborla cborla merged commit e06cb93 into main Apr 1, 2025
6 checks passed
@cborla cborla deleted the enhancement/694-define-a-default-configuration-per-platform branch April 1, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define a default configuration per platform

3 participants