-
Notifications
You must be signed in to change notification settings - Fork 56
Improve windows scaffolding #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4fb70c
to
437a970
Compare
26fc6bb
to
d21cb5f
Compare
jr0me
reviewed
Mar 27, 2025
edfd9b7
to
b9de00a
Compare
b9de00a
to
9531f09
Compare
jr0me
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
f438189
to
7cf9405
Compare
sdvendramini
approved these changes
Mar 28, 2025
aritosteles
approved these changes
Mar 28, 2025
7cf9405
to
2600708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds several improvements to the Windows scaffolding, as reported by #692. These changes also significantly reduce the MSI and installation size.
Proposed Changes
data_provider
anddbsync
cmake improvements.vcpkg
dependencies statically.Results and Evidence
Linux:
macOS:
Windows
Old sizes:
New sizes:
Artifacts Affected
Configuration Changes
N/A
Documentation Updates
N/A
Tests Introduced
N/A
Review Checklist