SCA define module interface #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jr0me
commented
Mar 31, 2025
jr0me
commented
Mar 31, 2025
jr0me
force-pushed
the
enhancement/680-sca-define-module-interface
branch
2 times, most recently
from
854eace to
fb1ae95
Compare
…t default DB file path
We'll have to figure out what to do if this path changes in the configuration file and a reload modules is triggered.
…interface It's not clear if this is needed atm
jr0me
force-pushed
the
enhancement/680-sca-define-module-interface
branch
from
fb1ae95 to
6d2a6cf
Compare
…ory and LogCollector patterns
TomasTurina
reviewed
Mar 31, 2025
TomasTurina
reviewed
Mar 31, 2025
TomasTurina
reviewed
Mar 31, 2025
TomasTurina
reviewed
Mar 31, 2025
TomasTurina
reviewed
Mar 31, 2025
jr0me
force-pushed
the
enhancement/680-sca-define-module-interface
branch
from
e8fe46b to
6225186
Compare
…sage in SecurityConfigurationAssessment class
jr0me
force-pushed
the
enhancement/680-sca-define-module-interface
branch
from
6225186 to
296c546
Compare
This will enable us to mock it more easily.
TomasTurina
reviewed
Mar 31, 2025
TomasTurina
reviewed
Mar 31, 2025
| |`ENABLE_CLANG_TIDY`|Check code with _clang-tidy_ (requires `clang-tidy-18`) |`ON`| | ||
| |`ENABLE_INVENTORY`|Enable Inventory module |`ON`| | ||
| |`ENABLE_LOGCOLLECTOR`|Enable Logcollector module|`ON`| | ||
| |`ENABLE_SCA`|Enable SCA module|`OFF`| |
There was a problem hiding this comment.
Suggested change
| |`ENABLE_SCA`|Enable SCA module|`OFF`| | |
| |`ENABLE_SCA`|Enable SCA module|`ON`| |
?
There was a problem hiding this comment.
We have to change this in the future.
TomasTurina
reviewed
Mar 31, 2025
It's already defined in IDBsync
TomasTurina
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #680
This PR includes an SCA class with the basic methods defined in the ModuleWrapper template interface. It serves as a starting point for the rest of the SCA development.
Proposed Changes
Configuration Changes
inventory.dbinstead oflocal.db.Documentation Updates
New page added for SCA.
Tests Introduced
Basic tests for SCA.
Review Checklist