Skip to content

Conversation

TomasTurina
Copy link
Member

@TomasTurina TomasTurina commented Mar 31, 2025

Description

This PR fixes compilation issues and problems with cmake versions.

Proposed Changes

  • Fix clang-tidy findings on macOS.
  • Stop using latest runners.
    • Linux: use ubuntu-24.04
    • macOS: use macos-14
    • Windows: use windows-2022
  • Install cmake 3.x (3.30.3) to avoid compilation issues with vcpkg dependencies.

Results and Evidence

Sources

Linux: https://github.com/wazuh/wazuh-agent/actions/runs/14205392734/job/39801828751?pr=711

macOS: https://github.com/wazuh/wazuh-agent/actions/runs/14205392734/job/39801829517?pr=711

Windows: https://github.com/wazuh/wazuh-agent/actions/runs/14205392734/job/39801829113?pr=711

Packages

Linux: https://github.com/wazuh/wazuh-agent/actions/runs/14206133423

macOS: https://github.com/wazuh/wazuh-agent/actions/runs/14206134789

Windows: https://github.com/wazuh/wazuh-agent/actions/runs/14206137344

Artifacts Affected

  • DEB
  • RPM
  • PKG
  • MSI

Configuration Changes

N/A

Documentation Updates

N/A

Tests Introduced

N/A

Review Checklist

  • Code changes reviewed
  • Relevant evidence provided
  • Tests cover the new functionality
  • Configuration changes documented
  • Developer documentation reflects the changes
  • Meets requirements and/or definition of done
  • No unresolved dependencies with other issues

@TomasTurina TomasTurina self-assigned this Mar 31, 2025
@TomasTurina TomasTurina force-pushed the fix/macos-clang-tidy branch 14 times, most recently from 41d651e to 358424a Compare April 1, 2025 18:27
@TomasTurina TomasTurina linked an issue Apr 1, 2025 that may be closed by this pull request
@TomasTurina TomasTurina force-pushed the fix/macos-clang-tidy branch 14 times, most recently from e97db8f to 5b35b37 Compare April 1, 2025 19:56
@TomasTurina TomasTurina force-pushed the fix/macos-clang-tidy branch 5 times, most recently from db25fd1 to ea6dca1 Compare April 1, 2025 20:29
@TomasTurina TomasTurina marked this pull request as ready for review April 1, 2025 20:36
Copy link
Member

@jr0me jr0me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomasTurina TomasTurina force-pushed the fix/macos-clang-tidy branch from c7e7001 to 771ea54 Compare April 1, 2025 21:11
@TomasTurina TomasTurina force-pushed the fix/macos-clang-tidy branch 4 times, most recently from 810cd38 to 168c908 Compare April 1, 2025 21:40
@TomasTurina TomasTurina force-pushed the fix/macos-clang-tidy branch from 168c908 to 945f428 Compare April 1, 2025 22:03
@TomasTurina TomasTurina changed the title Apply fixes to enable clang tidy on macOS Fix compilation issues Apr 1, 2025
@TomasTurina TomasTurina merged commit 8405b26 into main Apr 1, 2025
6 checks passed
@TomasTurina TomasTurina deleted the fix/macos-clang-tidy branch April 1, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support CMake 4.x

2 participants