Enhancement/72 remove ossechids conditional directives from the code #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasTurina
reviewed
Aug 14, 2024
| @@ -169,13 +169,11 @@ static void loop_all_pids(const char *ps, pid_t max_pid, int *_errors, int *_tot | |||
| } | |||
|
|
|||
| /* If we are run in the context of OSSEC-HIDS, sleep here (no rush) */ | |||
| @@ -38,7 +38,6 @@ int notify_rk(int rk_type, const char *msg) | |||
| return (0); | |||
| } | |||
|
|
|||
| #ifdef OSSECHIDS | |||
| /* When running in context of OSSEC-HIDS, send problem to the rootcheck queue */ | |||
| help_rootcheck(home_path); | ||
| break; | ||
| } | ||
| } | ||
| #ifdef WIN32 |
There was a problem hiding this comment.
If they work, I think we can keep these functions. Please test them, for example in version 4.9.0 (remove the ifdef so they compile), and we will see what to do.
There was a problem hiding this comment.
I tested with version 4.9.0, and the port check doesn't do anything, it just prints a message with printf. This check is performed according to the default agent configuration setting:
<localfile>
<log_format>full_command</log_format>
<command>netstat -tulpn | sed 's/\([[:alnum:]]\+\)\ \+[[:digit:]]\+\ \+[[:digit:]]\+\ \+\(.*\):\([[:digit:]]*\)\ \+\([0-9\.\:\*]\+\).\+\ \([[:digit:]]*\/[[:alnum:]\-]*\).*/\1 \2 == \3 == \4 \5/' | sort -k 4 -g | sed 's/ == \(.*\) ==/:\1/' | sed 1,2d</command>
<alias>netstat listening ports</alias>
<frequency>360</frequency>
</localfile>
The port check of Rootcheck has been removed.
sdvendramini
force-pushed
the
enhancement/72-remove-ossechids-conditional-directives-from-the-code
branch
from
9dace30
to
b8ed3fa
Compare
TomasTurina
approved these changes
Aug 16, 2024
TomasTurina
deleted the
enhancement/72-remove-ossechids-conditional-directives-from-the-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Description
This PR adds the changes to delete the use of the OSSECHIDS conditional directive and remove any unnecessary code used along with these directives.