Skip to content

Conversation

vikman90
Copy link
Member

@vikman90 vikman90 commented Jun 17, 2025

Description

This pull request resolves an issue occurring during the extraction of build artifacts on macOS, where the system rejects creating absolute paths such as /Users/runner/.... The error is caused by a mismatch between the build environment (GitHub Actions) and the packaging environment (internal VPN host).

Proposed Changes

  • Avoid including the full absolute directory structure in the compressed build artifact.
  • Transfer only relevant subdirectories: src, build, and the install directory generated by cmake --install.
  • On the packaging host, relocate the install tree instead of re-installing or decompressing into protected system paths.

This change isolates build and install steps cleanly and ensures compatibility between CI and VPN hosts.

Results and Evidence

  • The archive now only contains relative paths:
    • wazuh-agent/src
    • wazuh-agent/build
    • wazuh-agent/install
  • Decompression and relocation succeed without requiring root or writing to protected locations.
  • The packaging scripts correctly consume the relocated install structure.
Status Workflow Run
🟢 6_builderpackage_agent-macos #37

Artifacts Affected

  • macOS Wazuh agent installer package (.pkg)
  • Intermediate ZIP artifact for ARM64 architecture

Configuration Changes

None required.

Documentation Updates

Not applicable.

Tests Introduced

No new tests introduced.

Installation and uninstallation tests continue to pass and validate the new install directory structure.

Review Checklist

  • Code changes reviewed
  • Relevant evidence provided
  • Tests cover the new functionality
  • Configuration changes documented
  • Developer documentation reflects the changes
  • Meets requirements and/or definition of done
  • No unresolved dependencies with other issues

@vikman90 vikman90 requested a review from MarcelKemp June 17, 2025 15:54
@vikman90 vikman90 self-assigned this Jun 17, 2025
@vikman90 vikman90 force-pushed the fix/351-unzip-macos-binaries branch from 7989e0d to ae1db2e Compare June 17, 2025 16:07
Copy link
Member

@MarcelKemp MarcelKemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vikman90 vikman90 merged commit 927df48 into main Jun 18, 2025
7 checks passed
@vikman90 vikman90 deleted the fix/351-unzip-macos-binaries branch June 18, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants