Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix for pull request and fix provision playbook reference in test workflows #136

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

Enaraque
Copy link
Member

@Enaraque Enaraque commented Nov 6, 2024

Description

The purpose of this PR is to fix various bugs found in the installation assistant's test workflows.

Firstly, Ubuntu 22 has been added to the Test_installation_assistant matrix as a system, ensuring it functions correctly on pull requests, and the condition in the Test_installation_assistant_distributed matrix has also been fixed.

Additionally, the environment variable WAZUH_INSTALLATION_ASSISTANT_REFERENCE has been added so that if a pull request triggers the workflow, it uses the branch that activated it (github.head_ref) as a reference. If triggered manually, it will use the corresponding input (WAZUH_INSTALLATION_ASSISTANT_REFERENCE).

Lastly, some of the variables used in the workflow, like VERBOSITY and AUTOMATION_REFERENCE, were only set when the workflow was triggered manually. This caused the steps that required these variables to fail when the workflow was run via a pull request. This has been resolved by adding environment variables with the same names and setting the correct values based on how the workflow was triggered.

Testing

Manually executed workflows

Pull Request executed workflows

Related issue

@Enaraque Enaraque self-assigned this Nov 6, 2024
@Enaraque Enaraque requested a review from a team November 6, 2024 16:45
@Enaraque Enaraque linked an issue Nov 6, 2024 that may be closed by this pull request
4 tasks
teddytpc1
teddytpc1 previously approved these changes Nov 6, 2024
@Enaraque Enaraque changed the title Add matrix for pull request and fix reference in provision playbook in test workflows Add matrix for pull request and fix provision playbook reference in test workflows Nov 8, 2024
@c-bordon c-bordon merged commit ecfbad0 into 4.10.2 Nov 8, 2024
@c-bordon c-bordon deleted the bug/135-test-workflows-do-not-perform-as-expected branch November 8, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test workflows do not perform as expected
3 participants