Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve query pass to wazuhdb #26865

Open
wants to merge 2 commits into
base: 4.10.2
Choose a base branch
from
Open

Improve query pass to wazuhdb #26865

wants to merge 2 commits into from

Conversation

GabrielEValenzuela
Copy link
Member

Objective

This PR aims to add a validation step for the incoming query sent from analysisd to the wazuhdb

@GabrielEValenzuela GabrielEValenzuela self-assigned this Nov 14, 2024
@GabrielEValenzuela GabrielEValenzuela force-pushed the bug/1749-improve-query-validation-wazuhdb branch from 2e4974c to fb283e0 Compare November 15, 2024 00:41
pereyra-m
pereyra-m requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@pereyra-m pereyra-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj!

src/analysisd/decoders/dbsync.c Outdated Show resolved Hide resolved
src/analysisd/decoders/dbsync.c Outdated Show resolved Hide resolved
src/analysisd/decoders/dbsync.c Outdated Show resolved Hide resolved
src/analysisd/decoders/dbsync.c Outdated Show resolved Hide resolved
src/wazuh_db/wdb_shared.c Outdated Show resolved Hide resolved
src/shared/wazuhdb_op.c Outdated Show resolved Hide resolved
src/headers/wazuhdb_op.h Outdated Show resolved Hide resolved
src/unit_tests/shared/test_wazuhdb_op.c Outdated Show resolved Hide resolved
src/wazuh_db/wdb_shared.c Outdated Show resolved Hide resolved
@GabrielEValenzuela
CL
cc42fa6 
- Add component validation in dbsync

- Add UTs
@GabrielEValenzuela GabrielEValenzuela force-pushed the bug/1749-improve-query-validation-wazuhdb branch from fb283e0 to cc42fa6 Compare November 15, 2024 02:01
@GabrielEValenzuela
CL
a83c754 
- Change order logic

- Add case for ITs

- Improve list of commands
@GabrielEValenzuela GabrielEValenzuela force-pushed the bug/1749-improve-query-validation-wazuhdb branch from 217286a to a83c754 Compare November 15, 2024 17:43
pereyra-m
pereyra-m approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@pereyra-m pereyra-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

I've reviewed the code.
To verify everything is working, I've installed the development branch and connected two agents v4.9.2 (Ubuntu 22 and Windows 10).

After the syscollector and syscheck scan , no error or warning messages were found

2024-11-15_18-06

Also, some invalid messages were sent and now are rejected as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereyra-m pereyra-m pereyra-m approved these changes

@Dwordcito Dwordcito Awaiting requested review from Dwordcito

@sebasfalcone sebasfalcone Awaiting requested review from sebasfalcone

Assignees

@GabrielEValenzuela GabrielEValenzuela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabrielEValenzuela @pereyra-m