Skip to content

Conversation

@abdalmoniem
Copy link
Contributor

Change-Id: I9640d3267b070f2622f91b3e64837e3e6f804977

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is A Sublime Text syntax definition for Nilesoft Shell Script files.

There are no packages like it in Package Control.

Change-Id: I9640d3267b070f2622f91b3e64837e3e6f804977
Signed-off-by: AbdAlMoniem AlHifnawy <[email protected]>
Removed the 'branch' key from the releases section.
@abdalmoniem abdalmoniem marked this pull request as draft November 19, 2025 23:32
@abdalmoniem abdalmoniem marked this pull request as ready for review November 19, 2025 23:32
@braver
Copy link
Collaborator

braver commented Nov 23, 2025

Your package looks good, but we can't test it because the 1.0.0 tag points to the version that just has the LICENSE file in it. Tag the latest version of your repo so we can test and then ship it!

@braver braver added the feedback provided The changes and package have been seen by a reviewer label Nov 23, 2025
abdalmoniem and others added 2 commits November 24, 2025 00:08
Co-authored-by: Koen Lageveen <[email protected]>
Co-authored-by: Koen Lageveen <[email protected]>
@abdalmoniem
Copy link
Contributor Author

abdalmoniem commented Nov 23, 2025

Your package looks good, but we can't test it because the 1.0.0 tag points to the version that just has the LICENSE file in it. Tag the latest version of your repo so we can test and then ship it!

done ☺️

@braver braver merged commit e6c2c43 into wbond:master Nov 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants