Skip to content

Commit

Permalink
Update nrjavaserial to 3.20.0
Browse files Browse the repository at this point in the history
Updates nrjavaserial to the official 3.20.0 release (compatible with Java 8/11).
With the upgraded version the library will no longer crash the Java 11 VM on Windows.
The native libraries now use the built in RXTX lockfiles instead of the previously used (OS dependent) liblockdev whereas the OH build didn't use any lockfiles at all.
It also has a fix for errors being printed when scanning for serial ports whenever a serial port is locked (NeuronRobotics/nrjavaserial#166).
With the new version RXTX threads also have proper names and there is a fix for an IllegalMonitorStateException that might occur when closing ports.

Fixes openhab#1384

Signed-off-by: Wouter Born <[email protected]>
  • Loading branch information
wborn committed Apr 14, 2020
1 parent b770bb1 commit 5503475
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 14 deletions.
2 changes: 1 addition & 1 deletion bom/compile/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@
<dependency>
<groupId>com.neuronrobotics</groupId>
<artifactId>nrjavaserial</artifactId>
<version>3.14.0</version>
<version>3.20.0</version>
<scope>compile</scope>
</dependency>

Expand Down
9 changes: 2 additions & 7 deletions bom/runtime/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -466,14 +466,9 @@

<!-- All serial transports -->
<dependency>
<groupId>org.openhab</groupId>
<groupId>com.neuronrobotics</groupId>
<artifactId>nrjavaserial</artifactId>
<!-- Use "no liblockdev" version -->
<!-- See: https://github.com/openhab/openhab-core/pull/761 -->
<!-- See: https://github.com/openhab/openhab-core/issues/750 -->
<!-- <groupId>com.neuronrobotics</groupId> -->
<!-- <version>3.15.0</version> -->
<version>3.15.0.OH2</version>
<version>3.20.0</version>
<scope>compile</scope>
</dependency>

Expand Down
7 changes: 1 addition & 6 deletions features/karaf/openhab-tp/src/main/feature/feature.xml
Original file line number Diff line number Diff line change
Expand Up @@ -214,12 +214,7 @@

<feature name="openhab.tp-serial-rxtx" version="${project.version}">
<capability>openhab.tp;feature=serial;impl=rxtx</capability>

<!-- Use "no liblockdev" version -->
<!-- See: https://github.com/openhab/openhab-core/pull/761 -->
<!-- See: https://github.com/openhab/openhab-core/issues/750 -->
<!-- <bundle>mvn:com.neuronrobotics/nrjavaserial/3.15.0</bundle> -->
<bundle>mvn:org.openhab/nrjavaserial/3.15.0.OH2</bundle>
<bundle>mvn:com.neuronrobotics/nrjavaserial/3.20.0</bundle>
</feature>

<feature name="openhab.tp-xtext" description="Xtext - Language Engineering Made Easy"
Expand Down

0 comments on commit 5503475

Please sign in to comment.