NFC-82 NFC signing support for web-eid example #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanderKondratjevNortal
force-pushed
the
NFC-82
branch
2 times, most recently
from
d07073a to
7ea942c
Compare
mrts
requested changes
Nov 25, 2025
example/src/main/java/eu/webeid/example/config/WebEidAuthTokenProperties.java
Outdated
Show resolved
Hide resolved
example/src/main/java/eu/webeid/example/config/WebEidAuthTokenProperties.java
Outdated
Show resolved
Hide resolved
SanderKondratjevNortal
force-pushed
the
NFC-82
branch
3 times, most recently
from
282bc12 to
71877fd
Compare
mrts
approved these changes
Dec 2, 2025
SanderKondratjevNortal
force-pushed
the
NFC-82
branch
from
da04aff to
e22d738
Compare
Signed-off-by: Sander Kondratjev <[email protected]>
Signed-off-by: Sander Kondratjev [email protected]
Signed-off-by: Sander Kondratjev [email protected]
SanderKondratjevNortal
force-pushed
the
NFC-82
branch
from
e22d738 to
a45b481
Compare
|
mrts
reviewed
Dec 11, 2025
Comment on lines
50
to
53
| private final int TOKEN_MIN_LENGTH = 100; | ||
| private final int TOKEN_MAX_LENGTH = 10000; | ||
|
|
||
| private final ObjectReader TOKEN_READER = new ObjectMapper().readerFor(WebEidAuthToken.class); |
Member
There was a problem hiding this comment.
Noticed that static is missing from constants:
Suggested change
| private static final int TOKEN_MIN_LENGTH = 100; | |
| private static final int TOKEN_MAX_LENGTH = 10000; | |
| private static final ObjectReader TOKEN_READER = new ObjectMapper().readerFor(WebEidAuthToken.class); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sander Kondratjev [email protected]