Add bindings for context menu API #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR adds support for the Chrome's ContextMenus API
According to the Firefox docs, Firefox should also support this API to the same level as Chrome, but they also have additional properties. I'm not sure how best to support them as well have a different namespace,
menusvscontextMenusThere is also a case where certain properties return
number|stringwhich I was not sure how to model them asOption<JsValue>is not possible. One option would be drop theOptionpart and use justJsValueI also have the structs for the
OnClickDataand thecreatePropertiesobject, but I'm not sure if they should be in this crate or theweb-extensionsone.Also, I'm not that familiar with Rust yet, so let me know if anything needs changes