Skip to content

fix: source map files should always be excluded from resource hints #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

chenjiahan
Copy link
Member

Summary

When using performance.prefetch or performance.preload, the source map files should always be excluded, regardless of whether the user has configured a custom exclude option.

Related Links

Fix Modern.js E2E cases: https://github.com/web-infra-dev/modern.js/actions/runs/14632877492/job/41058294609

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 373ca0c
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6809b800862e4c000838d5f4
😎 Deploy Preview https://deploy-preview-5090--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 81 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 508d926 into main Apr 24, 2025
12 checks passed
@chenjiahan chenjiahan deleted the source_map_resource_hints_0424 branch April 24, 2025 04:57
@chenjiahan chenjiahan mentioned this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant