chore: enable noUncheckedSideEffectImports in tsconfig.json#5384
Merged
chenjiahan merged 1 commit intomainfrom Jun 8, 2025
Merged
chore: enable noUncheckedSideEffectImports in tsconfig.json#5384chenjiahan merged 1 commit intomainfrom
noUncheckedSideEffectImports in tsconfig.json#5384chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enables stricter import checks by turning on the noUncheckedSideEffectImports compiler option.
- Adds the new flag to the base
tsconfig.jsonto prevent unnoticed side-effect imports. - Leaves checklist for tests/docs but no updates added there.
Comments suppressed due to low confidence (2)
scripts/config/tsconfig.json:20
- [nitpick] Consider adding a note to the project’s README or contributing guide explaining the implications of
noUncheckedSideEffectImportsand how to opt back in when needed.
"noUncheckedSideEffectImports": true
scripts/config/tsconfig.json:20
- [nitpick] Verify that all downstream tsconfig files in sub-packages extend this base config so they also enforce the new side-effect import checks consistently.
"noUncheckedSideEffectImports": true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
To avoid side effect imports, enable the
noUncheckedSideEffectImportssetting in tsconfig.json for Rsbuild packages.Related Links
Checklist