Skip to content

feat(types): add type declarations for normal CSS module #5385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2025

Conversation

chenjiahan
Copy link
Member

Summary

Add type declarations for normal CSS module, this is required when TypeScript's new noUncheckedSideEffectImports option is enabled.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings June 8, 2025 09:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link

netlify bot commented Jun 8, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 57d14f8
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/684556e24d159600089c1986
😎 Deploy Preview https://deploy-preview-5385--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@chenjiahan chenjiahan merged commit 6055bb8 into main Jun 8, 2025
11 checks passed
@chenjiahan chenjiahan deleted the css_type_0608 branch June 8, 2025 11:07
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing type declaration for CSS imports that are not CSS Modules
1 participant