Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR adds a "types" field to the project’s tsconfig to narrow type resolution to Node and speed up TypeScript compilation.
- Restricts global type definitions to only Node
- Aims to improve
tscperformance by limiting auto-included types
Comments suppressed due to low confidence (1)
scripts/config/tsconfig.json:6
- [nitpick] Restricting to only 'node' types may unintentionally omit other globals (e.g., testing frameworks). Consider including all necessary environment types or documenting this change to prevent missing definitions.
"types": ["node"],
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Set types field in tsconfig, this should make
tsca bit faster.Related Links
microsoft/TypeScript#58420 (comment)
Checklist