Skip to content

chore: set types field in tsconfig #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

chore: set types field in tsconfig #5400

merged 1 commit into from
Jun 11, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jun 11, 2025

Summary

Set types field in tsconfig, this should make tsc a bit faster.

Related Links

microsoft/TypeScript#58420 (comment)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings June 11, 2025 09:46
Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 074898d
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/684950796b6c9e0008656b1b
😎 Deploy Preview https://deploy-preview-5400--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR adds a "types" field to the project’s tsconfig to narrow type resolution to Node and speed up TypeScript compilation.

  • Restricts global type definitions to only Node
  • Aims to improve tsc performance by limiting auto-included types
Comments suppressed due to low confidence (1)

scripts/config/tsconfig.json:6

  • [nitpick] Restricting to only 'node' types may unintentionally omit other globals (e.g., testing frameworks). Consider including all necessary environment types or documenting this change to prevent missing definitions.
"types": ["node"],

@chenjiahan chenjiahan merged commit 4e5285c into main Jun 11, 2025
12 of 13 checks passed
@chenjiahan chenjiahan deleted the tsconfig_node_0611 branch June 11, 2025 09:58
@chenjiahan chenjiahan mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant