Skip to content

feat: allow log level to be silent #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

feat: allow log level to be silent #5426

merged 1 commit into from
Jun 16, 2025

Conversation

chenjiahan
Copy link
Member

Summary

  • Upgraded rslog dependency from version ^1.2.3 to ^1.2.6.
  • Added a new silent log level to the logLevel config.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 05:33
Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 4ab6363
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/684facab342940000870f4ce
😎 Deploy Preview https://deploy-preview-5426--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (🔴 down 8 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the rslog dependency and introduces a new silent log level to suppress all logs.

  • Bump rslog from ^1.2.3 to ^1.2.6
  • Extend logLevel union type and docs to include 'silent'

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/core/src/types/config.ts Added 'silent' option and documentation
packages/core/package.json Updated rslog dependency version
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

packages/core/src/types/config.ts:1786

  • Add tests to verify that the new 'silent' logLevel correctly suppresses all logs in the logging module.
  logLevel?: 'info' | 'warn' | 'error' | 'silent';

@chenjiahan chenjiahan merged commit 6d67151 into main Jun 16, 2025
12 checks passed
@chenjiahan chenjiahan deleted the log_silent_0616 branch June 16, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant