refactor: use Rslib to build packages #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fi3ework
force-pushed
the
rslib-2
branch
3 times, most recently
from
f416b68 to
d03e521
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the build system from Modern.js to Rslib across multiple packages in the RsDoctor monorepo. The migration involves updating build commands, replacing configuration files, and adjusting ESM output file extensions.
Key changes:
- Replace Modern.js build tooling with Rslib across packages
- Create new shared Rslib configuration in
scripts/rslib.base.config.ts - Update ESM output file extensions from
.jsto.mjsfor better module resolution
Reviewed Changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/rslib.base.config.ts | Adds new shared Rslib build configuration with CommonJS and ESM format support |
| scripts/modern.base.config.ts | Removes deprecated ESM configuration that's been migrated to Rslib |
| packages/*/package.json | Updates build scripts from "modern build" to "rslib build" and adds @rslib/core dependency |
| packages/*/rslib.config.ts | Adds Rslib configuration files replacing Modern.js configs |
| packages/*/modern.config.ts | Removes old Modern.js configuration files |
| packages/utils/package.json | Updates ESM export paths from .js to .mjs extensions |
Comments suppressed due to low confidence (1)
packages/rspack-plugin/rslib.config.ts:3
- [nitpick] The variable name 'rslibConfig' is redundant since this is already in an rslib config file. Consider renaming to 'config' for brevity.
const rslibConfig = {
|
The @modern-js/module-tools package in the root/package.json dependencies may be unnecessary and can possibly be removed. |
easy1090
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
not finished yet, i found some wrong output instatic-commonjsexport format, which need to be fixed ahead.i made a mistake, there was no bug, we could migrate some packages in this PR.
@rsdoctor/corehas a circular require and will be migrated in another separated PR.Related Links