Skip to content

perf: js loader runner #10477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf: js loader runner #10477

wants to merge 3 commits into from
+139 −17

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented May 26, 2025

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented May 26, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 7537b7b
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6836aef24255670008f8b8ab
😎 Deploy Preview https://deploy-preview-10477--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels May 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 26, 2025 •
edited
Loading

📝 Benchmark detail: Open

task failure

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 26, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10477 will not alter performance

Comparing perf-js-loader-runner (7537b7b) with main (792ad27)

Summary

✅ 11 untouched benchmarks

quininer
quininer reviewed May 26, 2025
View reviewed changes
crates/node_binding/src/plugins/js_loader/mod.rs
where
Value: FromNapiValue,
{
let mut callback_values = [ptr::null_mut()];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use ptr::from_mut instead of this trick

@SyMind SyMind force-pushed the perf-js-loader-runner branch from da70981 to e0c593b Compare May 27, 2025 09:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 27, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-05-27 890ae6d) Current Change
10000_big_production-mode_disable-minimize + exec 35.3 s ± 228 ms 36 s ± 781 ms +1.90 %
10000_development-mode + exec 1.88 s ± 44 ms 1.8 s ± 12 ms -4.39 %
10000_development-mode_hmr + exec 772 ms ± 10 ms 754 ms ± 29 ms -2.23 %
10000_production-mode + exec 2.33 s ± 38 ms 2.27 s ± 65 ms -2.58 %
10000_production-mode_persistent-cold + exec 2.48 s ± 17 ms 2.43 s ± 74 ms -2.28 %
10000_production-mode_persistent-hot + exec 1.77 s ± 14 ms 1.74 s ± 38 ms -1.57 %
arco-pro_development-mode + exec 1.81 s ± 120 ms 1.78 s ± 66 ms -1.48 %
arco-pro_development-mode_hmr + exec 383 ms ± 3 ms 383 ms ± 1.1 ms -0.07 %
arco-pro_production-mode + exec 3.42 s ± 64 ms 3.5 s ± 89 ms +2.30 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.56 s ± 195 ms 3.6 s ± 60 ms +1.07 %
arco-pro_production-mode_persistent-cold + exec 3.54 s ± 164 ms 3.61 s ± 235 ms +1.95 %
arco-pro_production-mode_persistent-hot + exec 2.13 s ± 31 ms 2.14 s ± 55 ms +0.12 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.46 s ± 87 ms 3.56 s ± 175 ms +2.80 %
large-dyn-imports_development-mode + exec 2.1 s ± 29 ms 2.04 s ± 22 ms -3.08 %
large-dyn-imports_production-mode + exec 2.1 s ± 21 ms 2.11 s ± 50 ms +0.35 %
threejs_development-mode_10x + exec 1.69 s ± 88 ms 1.65 s ± 202 ms -2.32 %
threejs_development-mode_10x_hmr + exec 871 ms ± 15 ms 853 ms ± 25 ms -2.12 %
threejs_production-mode_10x + exec 5.25 s ± 181 ms 5.14 s ± 44 ms -2.06 %
threejs_production-mode_10x_persistent-cold + exec 5.31 s ± 294 ms 5.21 s ± 58 ms -1.92 %
threejs_production-mode_10x_persistent-hot + exec 4.43 s ± 87 ms 4.44 s ± 376 ms +0.33 %
10000_big_production-mode_disable-minimize + rss memory 9266 MiB ± 98.9 MiB 9123 MiB ± 75.3 MiB -1.54 %
10000_development-mode + rss memory 651 MiB ± 15.8 MiB 661 MiB ± 20.5 MiB +1.44 %
10000_development-mode_hmr + rss memory 786 MiB ± 14.7 MiB 779 MiB ± 12.4 MiB -0.93 %
10000_production-mode + rss memory 644 MiB ± 1.84 MiB 653 MiB ± 16.9 MiB +1.40 %
10000_production-mode_persistent-cold + rss memory 768 MiB ± 44.4 MiB 758 MiB ± 25.4 MiB -1.31 %
10000_production-mode_persistent-hot + rss memory 762 MiB ± 44.3 MiB 746 MiB ± 69.9 MiB -2.15 %
arco-pro_development-mode + rss memory 593 MiB ± 32.5 MiB 597 MiB ± 95.8 MiB +0.73 %
arco-pro_development-mode_hmr + rss memory 501 MiB ± 44.7 MiB 500 MiB ± 32.4 MiB -0.16 %
arco-pro_production-mode + rss memory 686 MiB ± 65.2 MiB 685 MiB ± 70.4 MiB -0.22 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 688 MiB ± 29.7 MiB 716 MiB ± 77.9 MiB +4.13 %
arco-pro_production-mode_persistent-cold + rss memory 780 MiB ± 90.9 MiB 804 MiB ± 119 MiB +3.11 %
arco-pro_production-mode_persistent-hot + rss memory 638 MiB ± 63.1 MiB 660 MiB ± 77.1 MiB +3.39 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 697 MiB ± 52.6 MiB 709 MiB ± 70 MiB +1.61 %
large-dyn-imports_development-mode + rss memory 661 MiB ± 5.06 MiB 661 MiB ± 4.7 MiB +0.01 %
large-dyn-imports_production-mode + rss memory 544 MiB ± 6.26 MiB 549 MiB ± 4.77 MiB +0.81 %
threejs_development-mode_10x + rss memory 604 MiB ± 20.7 MiB 611 MiB ± 11.8 MiB +1.07 %
threejs_development-mode_10x_hmr + rss memory 739 MiB ± 20 MiB 732 MiB ± 30.2 MiB -0.96 %
threejs_production-mode_10x + rss memory 882 MiB ± 18.1 MiB 882 MiB ± 16.1 MiB -0.02 %
threejs_production-mode_10x_persistent-cold + rss memory 952 MiB ± 37.5 MiB 972 MiB ± 29.9 MiB +2.14 %
threejs_production-mode_10x_persistent-hot + rss memory 847 MiB ± 18 MiB 857 MiB ± 41.4 MiB +1.22 %

@web-infra-dev web-infra-dev deleted a comment from github-actions bot May 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 28, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-05-28 7000b52) Current Change
10000_big_production-mode_disable-minimize + exec 35.5 s ± 247 ms 36.1 s ± 679 ms +1.67 %
10000_development-mode + exec 1.88 s ± 15 ms 1.79 s ± 16 ms -4.69 %
10000_development-mode_hmr + exec 758 ms ± 31 ms 743 ms ± 15 ms -2.00 %
10000_production-mode + exec 2.32 s ± 69 ms 2.28 s ± 135 ms -1.88 %
10000_production-mode_persistent-cold + exec 2.5 s ± 19 ms 2.4 s ± 43 ms -3.88 %
10000_production-mode_persistent-hot + exec 1.77 s ± 17 ms 1.71 s ± 75 ms -3.30 %
arco-pro_development-mode + exec 1.79 s ± 78 ms 1.79 s ± 108 ms -0.38 %
arco-pro_development-mode_hmr + exec 383 ms ± 1.8 ms 383 ms ± 5.1 ms +0.18 %
arco-pro_production-mode + exec 3.41 s ± 105 ms 3.47 s ± 108 ms +1.87 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.58 s ± 144 ms 3.58 s ± 264 ms -0.03 %
arco-pro_production-mode_persistent-cold + exec 3.47 s ± 159 ms 3.58 s ± 285 ms +3.30 %
arco-pro_production-mode_persistent-hot + exec 2.15 s ± 71 ms 2.14 s ± 103 ms -0.65 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.45 s ± 72 ms 3.52 s ± 118 ms +2.14 %
large-dyn-imports_development-mode + exec 2.09 s ± 15 ms 2.03 s ± 40 ms -2.64 %
large-dyn-imports_production-mode + exec 2.1 s ± 31 ms 2.05 s ± 76 ms -2.34 %
threejs_development-mode_10x + exec 1.66 s ± 37 ms 1.62 s ± 41 ms -2.63 %
threejs_development-mode_10x_hmr + exec 870 ms ± 14 ms 849 ms ± 4.1 ms -2.36 %
threejs_production-mode_10x + exec 5.21 s ± 59 ms 5.15 s ± 242 ms -1.00 %
threejs_production-mode_10x_persistent-cold + exec 5.29 s ± 266 ms 5.2 s ± 132 ms -1.65 %
threejs_production-mode_10x_persistent-hot + exec 4.41 s ± 48 ms 4.37 s ± 61 ms -0.81 %
10000_big_production-mode_disable-minimize + rss memory 9297 MiB ± 471 MiB 9156 MiB ± 124 MiB -1.52 %
10000_development-mode + rss memory 652 MiB ± 16.8 MiB 671 MiB ± 20.5 MiB +2.84 %
10000_development-mode_hmr + rss memory 784 MiB ± 19 MiB 792 MiB ± 16.4 MiB +0.99 %
10000_production-mode + rss memory 648 MiB ± 28.2 MiB 686 MiB ± 23.5 MiB +5.87 %
10000_production-mode_persistent-cold + rss memory 770 MiB ± 59.1 MiB 789 MiB ± 18.1 MiB +2.51 %
10000_production-mode_persistent-hot + rss memory 764 MiB ± 44.3 MiB 761 MiB ± 41.5 MiB -0.35 %
arco-pro_development-mode + rss memory 590 MiB ± 37.5 MiB 592 MiB ± 73.1 MiB +0.43 %
arco-pro_development-mode_hmr + rss memory 500 MiB ± 91.9 MiB 512 MiB ± 40.5 MiB +2.26 %
arco-pro_production-mode + rss memory 687 MiB ± 94 MiB 736 MiB ± 79.5 MiB +7.25 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 707 MiB ± 65.4 MiB 719 MiB ± 54 MiB +1.61 %
arco-pro_production-mode_persistent-cold + rss memory 790 MiB ± 51.8 MiB 817 MiB ± 46.5 MiB +3.50 %
arco-pro_production-mode_persistent-hot + rss memory 667 MiB ± 33.6 MiB 678 MiB ± 34.3 MiB +1.66 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 705 MiB ± 48.4 MiB 723 MiB ± 69.4 MiB +2.50 %
large-dyn-imports_development-mode + rss memory 667 MiB ± 16.1 MiB 687 MiB ± 15.4 MiB +3.09 %
large-dyn-imports_production-mode + rss memory 549 MiB ± 10.1 MiB 570 MiB ± 15.1 MiB +3.84 %
threejs_development-mode_10x + rss memory 616 MiB ± 42.7 MiB 638 MiB ± 31.9 MiB +3.69 %
threejs_development-mode_10x_hmr + rss memory 742 MiB ± 27.6 MiB 753 MiB ± 10.8 MiB +1.56 %
threejs_production-mode_10x + rss memory 888 MiB ± 52.9 MiB 910 MiB ± 13.7 MiB +2.54 %
threejs_production-mode_10x_persistent-cold + rss memory 970 MiB ± 28.7 MiB 973 MiB ± 19.5 MiB +0.27 %
threejs_production-mode_10x_persistent-hot + rss memory 843 MiB ± 38.7 MiB 857 MiB ± 42.6 MiB +1.63 %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quininer quininer quininer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SyMind @quininer