Skip to content

perf: parallel get_runtime_hash #10523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf: parallel get_runtime_hash #10523

wants to merge 1 commit into from

Conversation

quininer
Copy link
Contributor

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented May 30, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 1d42a84
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/683ff0305006c20008657de8
😎 Deploy Preview https://deploy-preview-10523--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label May 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 30, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-05-30 8450da9) Current Change
10000_big_production-mode_disable-minimize + exec 35.6 s ± 755 ms 36.1 s ± 302 ms +1.41 %
10000_development-mode + exec 1.88 s ± 16 ms 1.79 s ± 21 ms -4.65 %
10000_development-mode_hmr + exec 759 ms ± 4.9 ms 744 ms ± 35 ms -2.02 %
10000_production-mode + exec 2.31 s ± 73 ms 2.21 s ± 30 ms -4.44 %
10000_production-mode_persistent-cold + exec 2.47 s ± 51 ms 2.33 s ± 30 ms -5.93 %
10000_production-mode_persistent-hot + exec 1.73 s ± 29 ms 1.66 s ± 31 ms -3.76 %
arco-pro_development-mode + exec 1.8 s ± 99 ms 1.79 s ± 107 ms -0.72 %
arco-pro_development-mode_hmr + exec 383 ms ± 1.6 ms 383 ms ± 2.7 ms -0.13 %
arco-pro_production-mode + exec 3.38 s ± 54 ms 3.46 s ± 105 ms +2.31 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.5 s ± 89 ms 3.69 s ± 352 ms +5.33 %
arco-pro_production-mode_persistent-cold + exec 3.5 s ± 154 ms 3.54 s ± 105 ms +1.20 %
arco-pro_production-mode_persistent-hot + exec 2.14 s ± 27 ms 2.14 s ± 81 ms +0.28 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.44 s ± 87 ms 3.48 s ± 85 ms +1.24 %
large-dyn-imports_development-mode + exec 2.15 s ± 181 ms 2.04 s ± 28 ms -5.11 %
large-dyn-imports_production-mode + exec 2.1 s ± 22 ms 2.08 s ± 43 ms -1.00 %
threejs_development-mode_10x + exec 1.67 s ± 90 ms 1.63 s ± 15 ms -2.42 %
threejs_development-mode_10x_hmr + exec 856 ms ± 23 ms 852 ms ± 21 ms -0.38 %
threejs_production-mode_10x + exec 5.16 s ± 30 ms 5.14 s ± 150 ms -0.36 %
threejs_production-mode_10x_persistent-cold + exec 5.2 s ± 24 ms 5.23 s ± 272 ms +0.44 %
threejs_production-mode_10x_persistent-hot + exec 4.45 s ± 317 ms 4.42 s ± 275 ms -0.66 %
10000_big_production-mode_disable-minimize + rss memory 9275 MiB ± 192 MiB 9109 MiB ± 100 MiB -1.80 %
10000_development-mode + rss memory 651 MiB ± 27.2 MiB 640 MiB ± 29 MiB -1.73 %
10000_development-mode_hmr + rss memory 783 MiB ± 4.05 MiB 768 MiB ± 14.8 MiB -1.91 %
10000_production-mode + rss memory 646 MiB ± 12.9 MiB 648 MiB ± 24.6 MiB +0.33 %
10000_production-mode_persistent-cold + rss memory 760 MiB ± 32.2 MiB 746 MiB ± 20.9 MiB -1.74 %
10000_production-mode_persistent-hot + rss memory 751 MiB ± 48.1 MiB 742 MiB ± 24.9 MiB -1.18 %
arco-pro_development-mode + rss memory 582 MiB ± 64 MiB 555 MiB ± 66.2 MiB -4.68 %
arco-pro_development-mode_hmr + rss memory 487 MiB ± 64.7 MiB 499 MiB ± 56.5 MiB +2.55 %
arco-pro_production-mode + rss memory 676 MiB ± 53.1 MiB 707 MiB ± 39.9 MiB +4.66 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 696 MiB ± 48.4 MiB 701 MiB ± 40.9 MiB +0.72 %
arco-pro_production-mode_persistent-cold + rss memory 784 MiB ± 102 MiB 804 MiB ± 42.8 MiB +2.57 %
arco-pro_production-mode_persistent-hot + rss memory 663 MiB ± 68.1 MiB 652 MiB ± 50.1 MiB -1.72 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 692 MiB ± 46.1 MiB 711 MiB ± 54.1 MiB +2.75 %
large-dyn-imports_development-mode + rss memory 657 MiB ± 8.69 MiB 666 MiB ± 11.2 MiB +1.31 %
large-dyn-imports_production-mode + rss memory 541 MiB ± 5.58 MiB 550 MiB ± 2.28 MiB +1.58 %
threejs_development-mode_10x + rss memory 608 MiB ± 11.8 MiB 610 MiB ± 24.6 MiB +0.30 %
threejs_development-mode_10x_hmr + rss memory 738 MiB ± 24.7 MiB 724 MiB ± 28 MiB -1.78 %
threejs_production-mode_10x + rss memory 879 MiB ± 33.6 MiB 883 MiB ± 35.1 MiB +0.53 %
threejs_production-mode_10x_persistent-cold + rss memory 949 MiB ± 16.9 MiB 954 MiB ± 19.9 MiB +0.53 %
threejs_production-mode_10x_persistent-hot + rss memory 846 MiB ± 50.4 MiB 858 MiB ± 51.6 MiB +1.44 %

Threshold exceeded: ["arco-pro_production-mode_generate-package-json-webpack-plugin + exec"]

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 30, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10523 will not alter performance

Comparing ou/par-hash (1d42a84) with main (9cb7d7f)

Summary

✅ 12 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 30, 2025 •
edited
Loading

📝 Benchmark detail: Open

task failure

@quininer quininer force-pushed the ou/par-hash branch 4 times, most recently from c265b7e to 63be006 Compare May 30, 2025 11:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 30, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-05-30 8450da9) Current Change
10000_big_production-mode_disable-minimize + exec 35.6 s ± 755 ms 35.8 s ± 467 ms +0.48 %
10000_development-mode + exec 1.88 s ± 16 ms 1.79 s ± 28 ms -4.92 %
10000_development-mode_hmr + exec 759 ms ± 4.9 ms 750 ms ± 31 ms -1.15 %
10000_production-mode + exec 2.31 s ± 73 ms 2.21 s ± 31 ms -4.37 %
10000_production-mode_persistent-cold + exec 2.47 s ± 51 ms 2.37 s ± 39 ms -4.33 %
10000_production-mode_persistent-hot + exec 1.73 s ± 29 ms 1.73 s ± 235 ms 0.00 %
arco-pro_development-mode + exec 1.8 s ± 99 ms 1.79 s ± 59 ms -0.56 %
arco-pro_development-mode_hmr + exec 383 ms ± 1.6 ms 382 ms ± 1.2 ms -0.24 %
arco-pro_production-mode + exec 3.38 s ± 54 ms 3.53 s ± 260 ms +4.52 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.5 s ± 89 ms 3.62 s ± 157 ms +3.58 %
arco-pro_production-mode_persistent-cold + exec 3.5 s ± 154 ms 3.59 s ± 192 ms +2.76 %
arco-pro_production-mode_persistent-hot + exec 2.14 s ± 27 ms 2.14 s ± 51 ms +0.22 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.44 s ± 87 ms 3.52 s ± 117 ms +2.45 %
large-dyn-imports_development-mode + exec 2.15 s ± 181 ms 2.04 s ± 52 ms -5.33 %
large-dyn-imports_production-mode + exec 2.1 s ± 22 ms 2.08 s ± 30 ms -0.87 %
threejs_development-mode_10x + exec 1.67 s ± 90 ms 1.65 s ± 45 ms -1.40 %
threejs_development-mode_10x_hmr + exec 856 ms ± 23 ms 850 ms ± 8.8 ms -0.61 %
threejs_production-mode_10x + exec 5.16 s ± 30 ms 5.18 s ± 251 ms +0.39 %
threejs_production-mode_10x_persistent-cold + exec 5.2 s ± 24 ms 5.28 s ± 229 ms +1.38 %
threejs_production-mode_10x_persistent-hot + exec 4.45 s ± 317 ms 4.4 s ± 96 ms -0.96 %
10000_big_production-mode_disable-minimize + rss memory 9275 MiB ± 192 MiB 9268 MiB ± 658 MiB -0.08 %
10000_development-mode + rss memory 651 MiB ± 27.2 MiB 685 MiB ± 30.1 MiB +5.11 %
10000_development-mode_hmr + rss memory 783 MiB ± 4.05 MiB 794 MiB ± 25.9 MiB +1.39 %
10000_production-mode + rss memory 646 MiB ± 12.9 MiB 687 MiB ± 42 MiB +6.22 %
10000_production-mode_persistent-cold + rss memory 760 MiB ± 32.2 MiB 803 MiB ± 16.3 MiB +5.75 %
10000_production-mode_persistent-hot + rss memory 751 MiB ± 48.1 MiB 774 MiB ± 44.6 MiB +3.13 %
arco-pro_development-mode + rss memory 582 MiB ± 64 MiB 615 MiB ± 43.5 MiB +5.60 %
arco-pro_development-mode_hmr + rss memory 487 MiB ± 64.7 MiB 501 MiB ± 45.1 MiB +2.99 %
arco-pro_production-mode + rss memory 676 MiB ± 53.1 MiB 756 MiB ± 107 MiB +11.90 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 696 MiB ± 48.4 MiB 765 MiB ± 68.8 MiB +9.97 %
arco-pro_production-mode_persistent-cold + rss memory 784 MiB ± 102 MiB 872 MiB ± 103 MiB +11.35 %
arco-pro_production-mode_persistent-hot + rss memory 663 MiB ± 68.1 MiB 665 MiB ± 38.2 MiB +0.29 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 692 MiB ± 46.1 MiB 769 MiB ± 32.6 MiB +11.25 %
large-dyn-imports_development-mode + rss memory 657 MiB ± 8.69 MiB 688 MiB ± 11.9 MiB +4.66 %
large-dyn-imports_production-mode + rss memory 541 MiB ± 5.58 MiB 566 MiB ± 8.92 MiB +4.68 %
threejs_development-mode_10x + rss memory 608 MiB ± 11.8 MiB 637 MiB ± 43.6 MiB +4.64 %
threejs_development-mode_10x_hmr + rss memory 738 MiB ± 24.7 MiB 757 MiB ± 27.9 MiB +2.64 %
threejs_production-mode_10x + rss memory 879 MiB ± 33.6 MiB 925 MiB ± 55.6 MiB +5.27 %
threejs_production-mode_10x_persistent-cold + rss memory 949 MiB ± 16.9 MiB 992 MiB ± 48.4 MiB +4.57 %
threejs_production-mode_10x_persistent-hot + rss memory 846 MiB ± 50.4 MiB 853 MiB ± 47.2 MiB +0.85 %

@quininer quininer marked this pull request as ready for review June 3, 2025 02:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-06-04 034dc61) Current Change
10000_big_production-mode_disable-minimize + exec 35.3 s ± 347 ms 35.9 s ± 427 ms +1.56 %
10000_development-mode + exec 1.86 s ± 25 ms 1.82 s ± 188 ms -1.80 %
10000_development-mode_hmr + exec 749 ms ± 26 ms 747 ms ± 26 ms -0.24 %
10000_production-mode + exec 2.28 s ± 41 ms 2.19 s ± 39 ms -3.93 %
10000_production-mode_persistent-cold + exec 2.46 s ± 172 ms 2.35 s ± 37 ms -4.54 %
10000_production-mode_persistent-hot + exec 1.71 s ± 24 ms 1.68 s ± 27 ms -1.97 %
arco-pro_development-mode + exec 1.78 s ± 41 ms 1.81 s ± 103 ms +1.21 %
arco-pro_development-mode_hmr + exec 383 ms ± 0.72 ms 383 ms ± 0.97 ms -0.10 %
arco-pro_production-mode + exec 3.38 s ± 24 ms 3.46 s ± 39 ms +2.20 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.51 s ± 160 ms 3.62 s ± 322 ms +3.16 %
arco-pro_production-mode_persistent-cold + exec 3.46 s ± 89 ms 3.54 s ± 100 ms +2.49 %
arco-pro_production-mode_persistent-hot + exec 2.12 s ± 51 ms 2.15 s ± 38 ms +1.21 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.47 s ± 316 ms 3.48 s ± 61 ms +0.48 %
large-dyn-imports_development-mode + exec 2.11 s ± 55 ms 2.04 s ± 30 ms -3.21 %
large-dyn-imports_production-mode + exec 2.09 s ± 48 ms 2.11 s ± 143 ms +0.58 %
threejs_development-mode_10x + exec 1.42 s ± 166 ms 1.38 s ± 27 ms -2.51 %
threejs_development-mode_10x_hmr + exec 843 ms ± 3.9 ms 848 ms ± 16 ms +0.58 %
threejs_production-mode_10x + exec 4.87 s ± 37 ms 4.88 s ± 36 ms +0.05 %
threejs_production-mode_10x_persistent-cold + exec 4.94 s ± 53 ms 4.92 s ± 89 ms -0.23 %
threejs_production-mode_10x_persistent-hot + exec 4.41 s ± 332 ms 4.38 s ± 90 ms -0.64 %
10000_big_production-mode_disable-minimize + rss memory 9337 MiB ± 487 MiB 9167 MiB ± 198 MiB -1.82 %
10000_development-mode + rss memory 650 MiB ± 12 MiB 649 MiB ± 7.2 MiB -0.21 %
10000_development-mode_hmr + rss memory 779 MiB ± 7.61 MiB 768 MiB ± 9.78 MiB -1.37 %
10000_production-mode + rss memory 640 MiB ± 35.1 MiB 650 MiB ± 39.4 MiB +1.54 %
10000_production-mode_persistent-cold + rss memory 758 MiB ± 36 MiB 758 MiB ± 20.1 MiB -0.10 %
10000_production-mode_persistent-hot + rss memory 745 MiB ± 35 MiB 742 MiB ± 20.8 MiB -0.40 %
arco-pro_development-mode + rss memory 582 MiB ± 55.6 MiB 564 MiB ± 63.1 MiB -3.23 %
arco-pro_development-mode_hmr + rss memory 491 MiB ± 45.8 MiB 481 MiB ± 40.5 MiB -2.07 %
arco-pro_production-mode + rss memory 668 MiB ± 49.8 MiB 739 MiB ± 78.8 MiB +10.74 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 684 MiB ± 52.7 MiB 756 MiB ± 119 MiB +10.57 %
arco-pro_production-mode_persistent-cold + rss memory 790 MiB ± 70.3 MiB 803 MiB ± 136 MiB +1.54 %
arco-pro_production-mode_persistent-hot + rss memory 644 MiB ± 61.5 MiB 662 MiB ± 34 MiB +2.70 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 711 MiB ± 29.1 MiB 727 MiB ± 112 MiB +2.22 %
large-dyn-imports_development-mode + rss memory 655 MiB ± 5.08 MiB 658 MiB ± 5.04 MiB +0.54 %
large-dyn-imports_production-mode + rss memory 544 MiB ± 1.56 MiB 546 MiB ± 11 MiB +0.39 %
threejs_development-mode_10x + rss memory 587 MiB ± 19.9 MiB 589 MiB ± 29.2 MiB +0.36 %
threejs_development-mode_10x_hmr + rss memory 780 MiB ± 36.1 MiB 773 MiB ± 55.6 MiB -0.93 %
threejs_production-mode_10x + rss memory 866 MiB ± 33.3 MiB 879 MiB ± 39 MiB +1.48 %
threejs_production-mode_10x_persistent-cold + rss memory 946 MiB ± 48.5 MiB 949 MiB ± 44.5 MiB +0.33 %
threejs_production-mode_10x_persistent-hot + rss memory 842 MiB ± 39.3 MiB 854 MiB ± 45.4 MiB +1.36 %

@quininer quininer marked this pull request as draft June 4, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release: performance release: performance related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@quininer