Skip to content

fix(url_plugin): return true to stop ast traverse #10570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nilptr
Copy link
Contributor

@nilptr nilptr commented Jun 4, 2025

Summary

fix #10546

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d61069a
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68403ea75426f100084e3d6f

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jun 4, 2025
Copy link

codspeed-hq bot commented Jun 4, 2025

CodSpeed Performance Report

Merging #10570 will not alter performance

Comparing nilptr:ning.chen/fix/new-url-magic-comment (d61069a) with main (0b4cbec)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 12 untouched benchmarks

Copy link
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahabhgk ahabhgk merged commit 1a3de46 into web-infra-dev:main Jun 9, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: webpackIgnore magic comment is not working for new URL calls
2 participants