Skip to content

feat: support extra head tags #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

antonio-ivanovski
Copy link

Summary

This PR adds support for extra head tags per page via Frontmatter config.

Related Issue

#1121

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 087d875
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/666874887e4da300088b30a5
😎 Deploy Preview https://deploy-preview-1145--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan requested a review from Timeless0911 June 3, 2024 14:22
@Timeless0911
Copy link
Contributor

Thxs, can you add a seperate new fixture for this feature instead?

@antonio-ivanovski
Copy link
Author

Thxs, can you add a seperate new fixture for this feature instead?

Done in 598cdc9

@antonio-ivanovski
Copy link
Author

Made changes as discussed in #1121

  • Now the header attributes are being applied in the build step
  • Made some changes to the loadFrontMatter typing so get better typing support on the build side.

@Timeless0911 please re-review

@antonio-ivanovski
Copy link
Author

@Timeless0911 please also consider the extension to this PR #1168

@Timeless0911
Copy link
Contributor

This PR looks like it can be closed now since #1168

@antonio-ivanovski
Copy link
Author

This PR looks like it can be closed now since #1168

Sounds good, only created it as separate PR to allow the one being approved and merged without the other in case it doesn't fit into the vision for Rspress.

Feel free to close this PR if not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants