Skip to content

test: add failing e2e case #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Apr 11, 2025

Summary

Related Issue

close #2053

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 11, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit 6e5a3f3
🔍 Latest deploy log https://app.netlify.com/sites/rspress-v2/deploys/67f8c7b8b042310007cbdfa9
😎 Deploy Preview https://deploy-preview-2052--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 11, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 6e5a3f3
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67f8c7b8e347060008ccdd70
😎 Deploy Preview https://deploy-preview-2052--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 8 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JounQin JounQin force-pushed the feat/url_symbol_link branch from aaf9eee to 27b90d9 Compare April 11, 2025 03:08
@JounQin
Copy link
Contributor Author

JounQin commented Apr 11, 2025

Found:

const relativePath = path.relative(root, file.path);

relativePath index.mdx
relativePath ../outside/index.mdx

The filepath following symlink results the problem, I'm trying to see if we can disable this behavior.

It seems been passed by rspack as this.resourcePath, I don't have enough knowledge about this part.

cc @SoonIter


Found https://webpack.js.org/configuration/resolve/#resolvesymlinks

image

But is's unavailable is rsbuild.

builderConfig.tools.rspack.resolve.symlink: false should be used.


When enable builderConfig.tools.rspack.resolve.symlink: false, it breaks pnpm...

image

For our yarn v4 project, it just works as expected.

cc @chenjiahan What do you think what can we do here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: path normalization doesn't handle symlink pointing outside docs correctly w or w/o mdxRs
1 participant