Skip to content

feat: change pnpm install packageName to pnpm add packageName on PackageManagerTabs #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

Marukome0743
Copy link
Contributor

@Marukome0743 Marukome0743 commented Jul 10, 2025

Summary

Align PackageManagerTabs with pnpm's CLI conventions by normalizing pnpm commands and using 'add' for package installation.

Enhancements:

  • Include pnpm in normalizeCommand logic alongside yarn and bun
  • Normalize pnpm commands in PackageManagerTabs
  • Switch pnpm dependency install commands from 'install' to 'add'

Tests:

  • Update E2E fixture to expect 'pnpm add rspress -D' instead of 'pnpm install rspress -D'

Appearance

Before After
before after

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit c3d4d5b
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/686f7c462da29a00089c33c0
😎 Deploy Preview https://deploy-preview-2364--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for rspress ready!

Name Link
🔨 Latest commit c3d4d5b
🔍 Latest deploy log https://app.netlify.com/projects/rspress/deploys/686f7c460a9197000864bc04
😎 Deploy Preview https://deploy-preview-2364--rspress.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 81 (🔴 down 15 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks❤️~

@SoonIter SoonIter merged commit 1b21ac3 into web-infra-dev:main Jul 10, 2025
12 checks passed
@SoonIter
Copy link
Member

I like the table you described; it is clear, easy to check, and of course, it has a distinct personality.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants