Skip to content

test: remove leftover node:path module from e2e tests #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

Marukome0743
Copy link
Contributor

Summary

Remove leftover references to the Node-specific node:path module from all end-to-end test fixtures and standardize on the built-in path import.

Enhancements:

  • Clean up test code by using the standard path module import

Tests:

  • Drop node:path imports from every e2e fixture’s index.test.ts file

Related Issue or Pull Request

The most of node:path was unnecessary when moved all the test files to its fixture folder at #2247.

Tip

You can remove unused imports using noUnusedImports rule in Biome.

      "correctness": {
        "useExhaustiveDependencies": "off",
+       "noUnusedImports": "error"
      },

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for rspress-v2 ready!

Name Link
🔨 Latest commit c528764
🔍 Latest deploy log https://app.netlify.com/projects/rspress-v2/deploys/68705a650c5ba00008e4aef0
😎 Deploy Preview https://deploy-preview-2369--rspress-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for rspress ready!

Name Link
🔨 Latest commit c528764
🔍 Latest deploy log https://app.netlify.com/projects/rspress/deploys/68705a65caa9820008fd4a2c
😎 Deploy Preview https://deploy-preview-2369--rspress.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🔴 down 24 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@JounQin JounQin merged commit efac98a into web-infra-dev:main Jul 11, 2025
12 of 14 checks passed
@Marukome0743 Marukome0743 deleted the node-path branch July 11, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants