Merged
Conversation
9 tasks
Collaborator
Author
|
@ddbeck Can you take a look at the BCD data? |
ddbeck
requested changes
Sep 24, 2024
Collaborator
ddbeck
left a comment
There was a problem hiding this comment.
I've filed mdn/browser-compat-data#24502 and made some minor suggestions to the name and description.
The BCD PR won't change the top-level status here—we're still checking the contexts where you can use it—but the per-key statuses will become different when BCD releases those changes.
features/path-shape.yml
Outdated
| @@ -0,0 +1,10 @@ | |||
| name: "`path()` shape" | |||
Collaborator
There was a problem hiding this comment.
These are plaintext, so you'll get literal backticks. I kinda wonder if this can't be very short though. What do you think?
Suggested change
| name: "`path()` shape" | |
| name: path() |
ddbeck
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #1649. BCD data needs investigation- see #1649 (comment)