Add type to alternatives in JSONSchema
#2697
Merged
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the alternatives field is described to be an array. But the type of item is missing. This change adds the type as string for each alternative.
|
Thanks for opening this, @jcscottiii. The JSON Schema is generated from Typescript types, so I'm not sure why this is missing already. I'll take a closer look at this soon. |
See-also: web-platform-dx#2722
|
It turned out to be a knotty problem. I've filed #2722 to sort out our schema generation. In the mean time, I've pushed a change to the types to allow the tests to pass here. This will get into the next release. |
ddbeck
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the alternatives field is described to be an array. But the
type of item is missing. This change adds the type as string for each alternative.