Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we're regenerating everything from scratch on each run, including BSF, there's no reason to not regenerate everything more often. The only downside here is that we will be changing the results for the yesterday/today on multiple occasions, rather than the figures being mostly constant once they're added.
See also #80/#81 where we previously landed/reverted this. The only difference here is we run
git-write.js
at the start ofbuild.sh
, to make sure the local copy of the results has been updated as recently as possible. (Of course, because the various scripts call the wpt.fyi API themselves there is still a risk of a new aligned run appearing between runninggit-write.js
and the actual scoring scripts, but that's relatively unlikely.) Ideally we'd update wpt-results-cache on demand from within each script as needed, but that's a much larger change, and also requires dealing with secrets to push to the other repo. This is almost certainly good enough for the vast majority of scheduled jobs, and even if the odd one fails we'll still have more up-to-date results than we had previously.