Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC adding third party Ed25519, HPKE, and CBOR libs #208

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

RFC adding third party Ed25519, HPKE, and CBOR libs #208

wants to merge 9 commits into from

Conversation

JensenPaul
Copy link

No description provided.

gsnedders
gsnedders reviewed Aug 23, 2024
View reviewed changes
rfcs/additional_cypto_cbor_libs.md Outdated Show resolved Hide resolved
rfcs/additional_cypto_cbor_libs.md Outdated Show resolved Hide resolved
rfcs/additional_cypto_cbor_libs.md Outdated Show resolved Hide resolved
rfcs/additional_cypto_cbor_libs.md Outdated Show resolved Hide resolved
rfcs/additional_cypto_cbor_libs.md Outdated Show resolved Hide resolved
rfcs/additional_cypto_cbor_libs.md Outdated Show resolved Hide resolved
@JensenPaul
use markdown link instead of footnotes
4c0957d
@JensenPaul
We also need Python HPKE & CBOR libraries
c3d0435 
wptserve needs to be able to decrypt and decode requests, and then encode and encrypt responses.
@xtlsheep xtlsheep mentioned this pull request Dec 9, 2024
Open
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 7, 2025

If the idea is to skip the CC0 library for now, please update the RFC along those lines

@JensenPaul
Copy link
Author

If the idea is to skip the CC0 library for now, please update the RFC along those lines

Based on comments 1,2,3 I hadn't planned on skipping the CC0 library.

I believe this RFC hasn't changed in 5 months and all comments are answered.

@past
Copy link
Member

past commented Jan 7, 2025

If the idea is to skip the CC0 library for now, please update the RFC along those lines

Based on comments 1,2,3 I hadn't planned on skipping the CC0 library.

I believe this RFC hasn't changed in 5 months and all comments are answered.

Including a CC0-licensed library (ed25519.py) is not resolved and there is no consensus in the WPT core team yet about it. Individual organizations need to consult their legal teams about it, which is going to take a while.

@JensenPaul
Copy link
Author

If the idea is to skip the CC0 library for now, please update the RFC along those lines

Based on comments 1,2,3 I hadn't planned on skipping the CC0 library.
I believe this RFC hasn't changed in 5 months and all comments are answered.

Including a CC0-licensed library (ed25519.py) is not resolved and there is no consensus in the WPT core team yet about it. Individual organizations need to consult their legal teams about it, which is going to take a while.

I've removed the CC0-licensed library from this RFC and added an MIT-licensed Ed25519 library to this RFC.

past
past approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@past past left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the latest change addresses the only remaining issue we had identified in our review. @gsnedders, @jgraham do you concur?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morlovich morlovich morlovich left review comments

@dadrian dadrian dadrian left review comments

@gsnedders gsnedders gsnedders left review comments

@Ms2ger Ms2ger Ms2ger left review comments

@alex alex alex left review comments

@past past past approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JensenPaul @Ms2ger @past @alex @gsnedders @dadrian @morlovich