Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unrestricted Promise usage in testharness.js #93

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

jgraham
Copy link
Contributor

@jgraham jgraham commented Aug 10, 2021

No description provided.

@annevk
Copy link
Member

annevk commented Aug 11, 2021

I was hoping for a policy that would have this as a side effect, but perhaps it's good to decide on this individually as well.

@jgraham
Copy link
Contributor Author

jgraham commented Aug 11, 2021

Yes, #92 is about overall policy, but this seems like low hanging fruit so worth splitting out into a smaller item.

web-platform-tests/wpt#29985 is a PR with the actual code changes to remove the support for testing testharness without the Promise constructor.

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 17, 2021

Ping @louaybassbouss about the WAVE comment in particular

@louaybassbouss
Copy link
Contributor

Ping @louaybassbouss about the WAVE comment in particular

Thanks @Ms2ger for pinging me let me check I will ASAP to you.

@jgraham
Copy link
Contributor Author

jgraham commented Sep 1, 2021

@louaybassbouss do you have an update here, or can we go ahead and merge this?

@FritzHeiden
Copy link

@louaybassbouss do you have an update here, or can we go ahead and merge this?

Looks good, go ahead and merge

@jgraham jgraham merged commit dc383d1 into master Sep 6, 2021
@jgraham jgraham deleted the testharness_promise branch September 6, 2021 14:05
@foolip
Copy link
Member

foolip commented Apr 5, 2022

It looks like the test cleanup for this never happened, so actually adding dependencies on Promise is still hard. I've sent web-platform-tests/wpt#33507.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants