Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest WPT Manifest for go_test #6958

Merged

Conversation

wptmetadata-bot
Copy link
Contributor

This automated pull request updates the MANIFEST.json file to the latest WPT manifest daily. GitHub checks run against this manifest. If checks fail in this PR, the failing metadata should be either renamed or deleted according to the WPT repository.

@github-actions github-actions bot enabled auto-merge (squash) November 26, 2024 13:24
auto-merge was automatically disabled November 27, 2024 13:23

Head branch was pushed to by a user without write access

@github-actions github-actions bot enabled auto-merge (squash) November 27, 2024 13:24
auto-merge was automatically disabled November 28, 2024 13:23

Head branch was pushed to by a user without write access

@github-actions github-actions bot enabled auto-merge (squash) November 28, 2024 13:24
auto-merge was automatically disabled November 29, 2024 13:23

Head branch was pushed to by a user without write access

@github-actions github-actions bot enabled auto-merge (squash) November 29, 2024 13:23
auto-merge was automatically disabled November 30, 2024 13:19

Head branch was pushed to by a user without write access

@github-actions github-actions bot enabled auto-merge (squash) November 30, 2024 13:19
auto-merge was automatically disabled December 1, 2024 13:20

Head branch was pushed to by a user without write access

@github-actions github-actions bot enabled auto-merge (squash) December 1, 2024 13:21
auto-merge was automatically disabled December 2, 2024 13:24

Head branch was pushed to by a user without write access

@github-actions github-actions bot enabled auto-merge (squash) December 2, 2024 13:24
@jcscottiii
Copy link
Collaborator

This is failing because of this PR: web-platform-tests/wpt#49342. Will need to remove/rename references

@jcscottiii
Copy link
Collaborator

@KyleJu Do you have an idea of what is going on? For example, I tried to modify the META.yml files and it still cannot find the test in the manifest.

For example. Given this file:

links:
- label: webperf
results:
- test: '*'
- product: chrome
url: https://crbug.com/1281880
results:
- test: idlharness-shadowrealm.window.html

I tried to change the test line value to:

idlharness.any.shadowrealm-in-window.html

But I see it there:

image

@KyleJu
Copy link
Contributor

KyleJu commented Dec 2, 2024

@jcscottiii with my limited knowledge in how testharness.js work, I believe that web-platform-tests/wpt#49342 introduced a new type of scope keywords, which is not the list of filename suffixes that wpt.fyi generates. It broke the manifest file generation.

Let's remove these renamed tests for now and merge this PR. It needs a fix on the manifest generation.

auto-merge was automatically disabled December 3, 2024 13:24

Head branch was pushed to by a user without write access

@github-actions github-actions bot enabled auto-merge (squash) December 3, 2024 13:24
@jcscottiii
Copy link
Collaborator

@KyleJu

Let's remove these renamed tests for now and merge this PR. It needs a fix on the manifest generation.

Done. Also, I filed #6974

@github-actions github-actions bot merged commit ce261f4 into web-platform-tests:master Dec 3, 2024
2 checks passed
@jcscottiii
Copy link
Collaborator

@Ms2ger I saw you commented on that PR. Would you happen to know how we could fix this problem?

@Ms2ger
Copy link

Ms2ger commented Dec 4, 2024

Not sure, unless this is the same issue @jgraham hit (and that I mentioned at the end of the meeting), where you need to regenerate the manifest from scratch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants