Fix #4009: reorder the registration of routes #4017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the mux docs, "Routes are tested in the order they were added to the router. If two routes match, the first one wins."
This means that
checks.RegisterRoutes()
needs to be called after everything else defining a route in /api/checks/ as it otherwise matches every path under /api/checks/.Fixes #4009; see also #4010. @past said in the latter said:
In way of minimal testing: