Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a consistent size for testharness.js #7642

Closed
gsnedders opened this issue Oct 9, 2017 · 6 comments
Closed

Use a consistent size for testharness.js #7642

gsnedders opened this issue Oct 9, 2017 · 6 comments

Comments

@gsnedders
Copy link
Member

See https://bugs.webkit.org/show_bug.cgi?id=178053

We guarantee a given size for reftests (well, modulo #7598), and not doing so appears to be causing problems for some testharness.js tests, so we should probably just guarantee a size for them too.

cc/ @youennf @cdumez [I can't find any GitHub account for Darin?] @jgraham @Ms2ger @foolip

@foolip
Copy link
Member

foolip commented Oct 9, 2017

Makes sense. What should the size be?

@gsnedders
Copy link
Member Author

I suggest we go for the same as we decide in #7598 to be consistent everywhere.

@foolip
Copy link
Member

foolip commented Nov 14, 2017

https://chromium-review.googlesource.com/c/chromium/src/+/768430 is a review where this is a problem. What is the size we'd guarantee, is it 800x600?

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 14, 2017

I think 600×600, but I thought that was a minimum, not a guaranteed size. I'm definitely not using that when running tests in the browser manually. Can that dialog test compute the expected result dynamically?

@foolip
Copy link
Member

foolip commented Nov 14, 2017

Yes, the dialog test could be written to work with any viewport size above some minimum size. But that would amount to saying that this issue is WontFix, and tests having to deal with it.

@gsnedders
Copy link
Member Author

Practically this is nowadays RFC material, and see web-platform-tests/rfcs#188 for an issue on the RFCs repo.

@gsnedders gsnedders closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants