State viewport height assumption and make a test fit that definition#45161
State viewport height assumption and make a test fit that definition#45161
Conversation
This matches the changes made to the img element test in #7644.
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham and
sideshowbarker
|
|
||
| * The device is a full-color device. | ||
| * The device has a viewport width of at least 800px. | ||
| * The device has viewport dimensions of at least 800px by 600px. |
There was a problem hiding this comment.
I wouldn't know. I was hoping that given the discussion in #7642 this was just missing information. Not sure I want to make the time to write an RFC for this.
There was a problem hiding this comment.
I think it's probably OK? Although having said that I don't think we currently enforce a minimum window size in wptrunner, except for reftests, so maybe we should have a followup issue to actually implement this? In which case a small RFC wouldn't hurt I think.
There was a problem hiding this comment.
I filed web-platform-tests/rfcs#188 as follow-up. Is that sufficient to land this change? I primarily care about getting this test fixed, but it seems good to update the documentation as well as per the discussion many years ago.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
5 participants
This matches the changes made to the img element test in #7644.