Make pytest raise warnings as errors by default #39829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
pytest.ini
wpt
wptrunner
gsnedders
commented
May 3, 2023
Comment on lines
+19
to
+20
| # https://github.com/web-platform-tests/wpt/issues/39366 | ||
| always:The metaschema specified by \$schema was not found\. Using the latest draft to validate, but this will raise an error in the future\.:DeprecationWarning |
Comment on lines
+21
to
+22
| # https://github.com/web-platform-tests/wpt/issues/39359 | ||
| always:'cgi' is deprecated and slated for removal in Python 3:DeprecationWarning |
Comment on lines
+23
to
+24
| # https://github.com/web-platform-tests/wpt/issues/39373 | ||
| always:the imp module is deprecated in favour of importlib:DeprecationWarning |
Comment on lines
+25
to
+26
| # https://github.com/web-platform-tests/wpt/issues/39827 | ||
| always:pkg_resources is deprecated as an API:DeprecationWarning |
jgraham
reviewed
May 5, 2023
jgraham
approved these changes
May 5, 2023
There was a problem hiding this comment.
I'm still mildly concerned that this might break people trying to run tests in their vendored copies, but I hope that doesn't happen and we can revert the change to actually make the tests error on warning if it does. So as long as we still see the warnings in the output, this seems OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.