Remove focus fixup for removal of <dialog open> attribute
#50668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the conversation here: whatwg/html#10953 (comment) This changes the behavior of the DialogCloseWhenOpenRemovedEnabled flag just a bit, to move toward "option 2" from the comment just below the one linked above. It also cleans up the two parameters to ::close(), and replaces them with one. And it stops doing the focus fixup behaviors in that case. Bug: 376516550 Change-Id: I072d710df47bbe58f5137070591378c72f8124b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6244982 Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1419540}
wpt-pr-bot
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the conversation here:
whatwg/html#10953 (comment)
This changes the behavior of the DialogCloseWhenOpenRemovedEnabled flag
just a bit, to move toward "option 2" from the comment just below the
one linked above. It also cleans up the two parameters to ::close(),
and replaces them with one. And it stops doing the focus fixup
behaviors in that case.
Bug: 376516550
Change-Id: I072d710df47bbe58f5137070591378c72f8124b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6244982
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1419540}