Add support for product plugins to wptrunner/wpt run#58022
Merged
gsnedders merged 7 commits intoweb-platform-tests:masterfrom Mar 14, 2026
Merged
Add support for product plugins to wptrunner/wpt run#58022gsnedders merged 7 commits intoweb-platform-tests:masterfrom
gsnedders merged 7 commits intoweb-platform-tests:masterfrom
Conversation
gsnedders
force-pushed
the
wptrunner_product_plugins
branch
from
9d39828 to
3b512e5
Compare
wpt-pr-bot
added
docs
infra
wpt
wptrunner
wpt-pr-bot
requested review from
DanielRyanSmith,
foolip,
jonathan-j-lee and
sideshowbarker
gsnedders
force-pushed
the
wptrunner_product_plugins
branch
2 times, most recently
from
5d3b993 to
3e2b48b
Compare
There's no point in large numbers of subclasses providing no-op implementations for a lot of these methods; the superclass may as well do it itself.
setup_kwargs has a clear, obvious no-op implementation, and is practically required already. ServoLegacy doesn't need to repeat what it inherits from Servo.
Since commit ca1d42c (June 14, 2017), which introduced the `wpt` command as a unified entry point, localpaths has been imported at the module level in tools/wpt/wpt.py before any command modules are loaded. Therefore, sys.path is guaranteed to include wptrunner and other tools before tools/wpt/run.py and tools/wpt/update.py are imported.
gsnedders
force-pushed
the
wptrunner_product_plugins
branch
from
3e2b48b to
b04a204
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of #57503, adding the ability to define products external to wptrunner. It probably makes sense to review that (the first commit on this branch) separately.