[carousel] Fix hover and active states for ::scroll-marker-group#58490
Draft
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Draft
[carousel] Fix hover and active states for ::scroll-marker-group#58490chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
When a ::scroll-marker is hovered or active, its associated ::scroll-marker-group should also match the :hover and :active pseudo-classes respectively. Since the group is not in the normal flat-tree ancestor chain of the marker, this patch overrides SetHovered and SetActive on ScrollMarkerPseudoElement to propagate these states to the ScrollMarkerGroupPseudoElement. Bug: 485920675 Change-Id: I26a47fe42363f19c7d0d39647fe10d2e7f953ecb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ::scroll-marker is hovered or active, its associated
::scroll-marker-group should also match the :hover and :active
pseudo-classes respectively. Since the group is not in the normal
flat-tree ancestor chain of the marker, this patch overrides
SetHovered and SetActive on ScrollMarkerPseudoElement to propagate
these states to the ScrollMarkerGroupPseudoElement.
Bug: 485920675
Change-Id: I26a47fe42363f19c7d0d39647fe10d2e7f953ecb
Reviewed-on: https://chromium-review.googlesource.com/7656807
WPT-Export-Revision: f9d5598e43228ffc311a232a7f70b47fd36db501