Prompt API: Reject on invalid constraints and prefix conflicts#58493
Draft
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Draft
Prompt API: Reject on invalid constraints and prefix conflicts#58493chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
Surface kInvalidConstraint via new mojom Error enum. Use this as the custom_reason for StreamingResponder disconnect. Bubble cancellation up via Blink ModelStreamingResponseStatus. Add unit tests and WPTs with basic Echo regex prefix checks. Bug: 391919456, 434766400, 454698388, 488433627 Change-Id: Ie3a918c238ed02b40334a4228690d7031310cd23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface kInvalidConstraint via new mojom Error enum.
Use this as the custom_reason for StreamingResponder disconnect.
Bubble cancellation up via Blink ModelStreamingResponseStatus.
Add unit tests and WPTs with basic Echo regex prefix checks.
Bug: 391919456, 434766400, 454698388, 488433627
Change-Id: Ie3a918c238ed02b40334a4228690d7031310cd23
Reviewed-on: https://chromium-review.googlesource.com/7654881
WPT-Export-Revision: 3a6e0b985ccb9d706abc9a78e32dbf6f900193ae