Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Indication message on Number Filter for Between #26

Conversation

kingmaker-agm
Copy link
Contributor

The Number Filter is showing the Wrong Indication when selected the Between mode of matching.

Image Reference

I have fixed the Issue in the PR. BTW, Thanks for the wonderful package.

@what-the-diff
Copy link

what-the-diff bot commented Jul 13, 2023

PR Summary

  • Updated Logic in NumberFilter.php File
    The basis of this update revolves around enhancing the labeling for a portion of our code where a 'between' condition is used. In the past, when this situation arose, labels would only contain 'from' and 'until' values; the new update introduces another element to the label, providing a more comprehensive overview of the whole 'between' clause, improving our system's communication and transparency.

@dmandrade
Copy link
Member

Thanks

@dmandrade dmandrade merged commit 8fd49dd into webbingbrasil:main Jul 17, 2023
@faizananwerali
Copy link
Contributor

Can you also fix the date and datetime filtering Indication message, that is also incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants