PoorlyDrawnLines: Fix after site redesign#329
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
==========================================
- Coverage 85.17% 85.05% -0.12%
==========================================
Files 79 79
Lines 7601 7617 +16
Branches 685 690 +5
==========================================
+ Hits 6474 6479 +5
- Misses 1004 1015 +11
Partials 123 123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0cb3794 to
2586aac
Compare
|
Update: The archive on this site is a bit of a mess, but this is working for now and is ready for review. There are a few dozen comics no longer available, but we also now correctly pull multi-image pages, so it seems to be a net-positive. I've implemented a skip list with I've hard-coded these to skip the broken redirects and go to the next comic that is still available. I assume these will get fixed at some point as only ~280 of ~1500 posts are now accessible using the normal site back button before it breaks. That said, this is working and I've confirmed that it pulls the entire back catalogue as best we can. |
2586aac to
5c27aab
Compare
5c27aab to
a9bc69e
Compare
|
Thanks for the fix and sorry for the late merge. The site seems to have changed again, I fixed that before merging... |
Hi folks. Poorly Drawn Lines seems to have had a recent redesign and is no longer working. This is a WIP fix, but I've hit an issue. Some pages are non-comic, e.g. promos for the TV show of the comic. These currently generate an error and bail out. I'm haven't found a way to suppress this for known pages without comics. Any advice here appreciated!
A few other notes:
multipleImagesPerStrip