feat: Alpha Support for Multi-remote Browser #1985
Draft
+1,929
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simple working case expecting one value
dprevost-LMI
force-pushed
the
support-multiremote
branch
from
f5096ff to
79e6464
Compare
dprevost-LMI
changed the title
dprevost-LMI
changed the title
dprevost-LMI
commented
Dec 31, 2025
dprevost-LMI
commented
Dec 31, 2025
dprevost-LMI
commented
Dec 31, 2025
| * @param isNot https://jestjs.io/docs/expect#thisisnot | ||
| * @param options wait, interval, etc | ||
| */ | ||
| const waitUntil = async ( |
Contributor
Author
There was a problem hiding this comment.
Potentially to revert to it's original since the above is now used
dprevost-LMI
commented
Dec 31, 2025
dprevost-LMI
changed the title
dprevost-LMI
changed the title
- Use `waitUntilResult` optimize to rerun per instance and now returns results with multiple information easing the processing. Also support condition returning an array of result or an array of promise - Use `formatFailureMessage` both compatible for multi-remote and not - Streamline and unify the processing of browser + get of actual value to use same algo to support easier both multi-remote and not multi-remote
dprevost-LMI
force-pushed
the
support-multiremote
branch
from
7853377 to
589a309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #106
PR serving as a starting point to support the multi-remote case.
toHaveTitlebrowser matcherswaitUntilwas reviewed to support multiple instances better so that we can retry only those that failed, optimizing the fetching process.CompareResultto be more flexible and returns more information for the assertions.Draft TODOs:
isNotis not always properly considered inwaitUntil#1982