feat(datachannel): add update subchannel subscriptions function by Tianhui-Han · Pull Request #4749 · webex/webex-js-sdk

Tianhui-Han · 2026-03-04T06:47:56Z

Add update subchannel subscriptions function

IMPORTANT
FAILING TO FILL OUT THIS TEMPLATE WILL RESULT IN REJECTION OF YOUR PULL REQUEST
This is for compliance purposes with FedRAMP program.
-->

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-763776

by making the following changes

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

I certified that

I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3c22b4ce0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-04T06:51:07Z

packages/@webex/internal-plugin-voicea/src/voicea.ts

+  public updateSubchannelSubscriptions = ({
+    subscribe = [],
+    unsubscribe = [],
+  }: {


Handle undefined options in updateSubchannelSubscriptions

This destructuring requires an argument object, so calling updateSubchannelSubscriptions() from JavaScript (or any untyped call path) throws a runtime TypeError before the isConnected() guard runs. Because the method already provides defaults for subscribe/unsubscribe, callers reasonably expect the no-arg form to behave like an empty update rather than crash; adding a default for the whole parameter (e.g., {}) avoids this production failure mode.

Useful? React with 👍 / 👎.

aws-amplify-us-east-2 · 2026-03-04T06:57:56Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4749.d3m3l2kee0btzx.amplifyapp.com

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d04435fcf4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-10T09:33:08Z

packages/@webex/internal-plugin-llm/src/llm.ts

+      const connectUrl = this.isDataChannelTokenEnabled()
+        ? LLMChannel.buildUrlWithAwareSubchannels(this.webSocketUrl, AWARE_DATA_CHANNEL)


Await token feature gate before selecting connect URL

isDataChannelTokenEnabled() returns a Promise<boolean>, but it is used directly in a ternary, so the condition is always truthy and buildUrlWithAwareSubchannels() runs even when the developer feature flag resolves to false. In environments where the flag is disabled, clients will still connect with subscriptionAwareSubchannels appended, which defeats the intended rollout gate and can change server behavior for all connections on this path.

Useful? React with 👍 / 👎.

…criptions

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84acaf49a0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-13T07:20:46Z

packages/@webex/internal-plugin-llm/src/llm.ts

      sessionData.datachannelToken = datachannelToken;
      this.connections.set(sessionId, sessionData);
-
+      const connectUrl = isDataChannelTokenEnabled


Resolve feature gate before URL selection

In registerAndConnect, the ternary reads isDataChannelTokenEnabled even though that identifier is not defined in this scope, so calling this method with valid locusUrl/datachannelUrl will throw a runtime ReferenceError before connect() runs. Because no-undef is disabled for TypeScript in this repo, this can slip through linting and break all LLM connection attempts on this path.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-13T07:20:46Z

packages/@webex/internal-plugin-llm/src/llm.ts

+      const connectUrl = isDataChannelTokenEnabled
+        ? LLMChannel.buildUrlWithAwareSubchannels(this.webSocketUrl, AWARE_DATA_CHANNEL)
+        : this.webSocketUrl;


Pass subscription-aware URL into connect

This block computes connectUrl with subscriptionAwareSubchannels, but the method still calls connect(sessionData.webSocketUrl, sessionId), so the new query parameter is never actually used. In environments expecting this flag-controlled URL decoration, clients will continue connecting with the unmodified WebSocket URL and the new feature will not take effect.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ac617cb11

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-13T07:53:59Z

packages/@webex/plugin-meetings/src/interceptors/utils.ts

@@ -0,0 +1,16 @@
+import * as jose from 'jose';


Declare jose in plugin-meetings runtime dependencies

isJwtTokenExpired now imports jose, but @webex/plugin-meetings does not declare jose in its dependencies (it only appears in packages/byods/package.json), so published consumers that install meetings without byods can hit Cannot find module 'jose' as soon as this interceptor module is loaded. Please add jose to packages/@webex/plugin-meetings/package.json so this new runtime import is always resolvable.

Useful? React with 👍 / 👎.

…criptions

mickelr · 2026-03-17T01:54:16Z

packages/@webex/internal-plugin-llm/src/llm.ts

-      return this.connect(sessionData.webSocketUrl, sessionId);
+      const isDataChannelTokenEnabled = await this.isDataChannelTokenEnabled();
+
+      const connectUrl = isDataChannelTokenEnabled


Should be isDataChannelTokenEnabled && datachannelToken, not noly the toggle is on but also the token is used when registration

mickelr · 2026-03-17T01:55:48Z

packages/@webex/internal-plugin-voicea/src/voicea.ts

+   * @param {string[]} options.unsubscribe Sub‑channels to unsubscribe from.
+   * @returns {void}
+   */
+  public updateSubchannelSubscriptions = ({


When the function is called?

feat(datachannel): add update subchannel subscriptions function

c3c22b4

Tianhui-Han requested review from a team as code owners March 4, 2026 06:47

chatgpt-codex-connector bot reviewed Mar 4, 2026

View reviewed changes

feat(datachannel): add aware data channel param

d04435f

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

Tianhui-Han and others added 2 commits March 11, 2026 09:14

feat(datachannel): fix logic

59b217d

Merge branch 'next' into feat/datachannel_update_sub_datachannel_subs…

84acaf4

…criptions

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

feat(jwt): refersh token when token is expired

9ac617c

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

Tianhui-Han and others added 4 commits March 16, 2026 10:23

feat(llm): resolve conflict

a0eaea2

feat(voicea): add jose dependencies

19435b9

Merge branch 'next' into feat/datachannel_update_sub_datachannel_subs…

fce3c84

…criptions

Merge branch 'next' into feat/datachannel_update_sub_datachannel_subs…

ef68a47

…criptions

mickelr requested changes Mar 17, 2026

View reviewed changes

mickelr reviewed Mar 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(datachannel): add update subchannel subscriptions function#4749

feat(datachannel): add update subchannel subscriptions function#4749
Tianhui-Han wants to merge 9 commits intowebex:nextfrom
Tianhui-Han:feat/datachannel_update_sub_datachannel_subscriptions

Tianhui-Han commented Mar 4, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 4, 2026

Uh oh!

aws-amplify-us-east-2 bot commented Mar 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Uh oh!

mickelr Mar 17, 2026

Uh oh!

mickelr Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const connectUrl = this.isDataChannelTokenEnabled()
		? LLMChannel.buildUrlWithAwareSubchannels(this.webSocketUrl, AWARE_DATA_CHANNEL)

Conversation

Tianhui-Han commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

I certified that

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

aws-amplify-us-east-2 bot commented Mar 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

mickelr Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

mickelr Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Tianhui-Han commented Mar 4, 2026 •

edited

Loading