Fix response parsing for MultipleItems requests #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
When using the
MultipleItems
class to create multiple items at once, the SDK incorrectly tried to parse the API response as aCollectionItem
object. However, when creating multiple items, the API returns a response with anitems
field containing a list of items, which should be parsed as aCollectionItemList
object.This caused a validation error:
Solution
I modified the
create_item
method inclient.py
to check if the request is aMultipleItems
object and, if so, parse the response as aCollectionItemList
instead of aCollectionItem
. This correctly handles the different response formats based on the request type.Changes:
typing.Union[CollectionItem, CollectionItemList]
Testing
I've tested this change by creating multiple items at once using the
MultipleItems
class, and the SDK now correctly parses the response without validation errors.